Implemented LICM. Added get_field_tests. Fixed compile.bash #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Oct 16, 2025
aeneas/src/main/Compiler.v3
Outdated
| var LocalRegAlloc = flags.get("LocalRegAlloc", level >= 1) && !CLOptions.DWARF.get(); | ||
| var NormOptimize = flags.get("NormOptimize", level >= 2); | ||
| var MachOptimize = flags.get("MachOptimize", level >= 2); | ||
| var LoopInvariantCodeMotion = flags.get("LoopInvariantCodeMotion", true); |
aeneas/src/ssa/SsaBlockOrder.v3
Outdated
| // and is used in linear scan register allocation and code generation. | ||
| def ON_STACK = -2; | ||
| def DONE = -3; | ||
| def ON_STACK: u31 = 1; |
There was a problem hiding this comment.
I'm not sure why these values need to be changed.
aeneas/src/ssa/SsaBlockOrder.v3
Outdated
| private var count: int; | ||
| private var list: List<SsaBlock>; | ||
| var loopEdges: List<SsaCfEdge>; | ||
| def marker = SsaExternalMarker.new(); |
There was a problem hiding this comment.
This should be an argument to the constructor.
| } | ||
| } | ||
| buf.putc('#').putd(b.uid).putc('m').putd(b.mark); | ||
| // buf.putc('#').putd(b.uid).putc('m').putd(b.mark); |
There was a problem hiding this comment.
It looks like this prints the output twice now.
aeneas/src/ssa/SsaOptimizer.v3
Outdated
| // Grab the next link in the current block. `link` could be hoisted elsewhere. | ||
| nextLink = link.next; | ||
| if (link.facts.O_PURE && SsaApplyOp.?(link) && | ||
| instrDominatesExitsAndBackedge(SsaInstr.!(link), curBlock, loopsInScope[loopsInScope.length - 1])) { |
There was a problem hiding this comment.
I think we don't need to check every instruction in the block, just that the block dominates.
aeneas/src/ssa/SsaOptimizer.v3
Outdated
| def instrDominatesExitsAndBackedge(instr: SsaInstr, curBlock: SsaBlock, loopInfo: SsaLoopInfo) -> bool { | ||
| var isValid: bool = true; | ||
| def header: SsaBlock = blockOrdering.order[loopInfo.start]; | ||
| def exits: Array<SsaCfEdge> = Lists.toArray(loopInfo.exits); |
There was a problem hiding this comment.
This is a little inefficient, since it makes a garbage array.
aeneas/src/ssa/SsaOptimizer.v3
Outdated
| continue; | ||
| } | ||
| def dominatesExit: bool = blockOrdering.isDominator(curBlock.info, exit.dest.info); | ||
| if (!dominatesExit && isValid) { |
There was a problem hiding this comment.
You could just early-return false here.
aeneas/src/ssa/SsaOptimizer.v3
Outdated
| if (!loopInfo.contains(predBlock)) { continue; } | ||
| // Check the current block dominates the predecessor | ||
| def dominatesPred: bool = blockOrdering.isDominator(curBlock.info, predBlock.info); | ||
| if (!dominatesPred && isValid) { |
There was a problem hiding this comment.
Same; you can early return false.
…o set ON_STACK and DONE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.