|
1 | | -## revdepcheck results |
2 | | - |
3 | | -We checked 23 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package. |
4 | | - |
5 | | - * We saw 0 new problems |
6 | | - * We failed to check 0 packages |
7 | | - |
8 | | -## 1.2.0 Submission |
9 | | - |
10 | | -This is a minor release of hardhat that rolls back some of the changes made in |
11 | | -hardhat 1.0.0. |
12 | | - |
13 | | -## 1.1.0 Submission |
14 | | - |
15 | | -This is a minor release of hardhat that follows up on the 1.0.0 release to fix |
16 | | -a bug that we accidentally introduced. Models fit with hardhat 0.2.0 were no |
17 | | -longer able to call `predict()` if hardhat 1.0.0 was installed. That was |
18 | | -unintentional, and has been fixed. |
19 | | - |
20 | | -## 1.0.0 Submission |
21 | | - |
22 | | -This is a major release of hardhat to signify that we feel that it is stable. It includes a breaking change regarding how recipe roles are handled in `forge()`. It also includes a few new functions useful for case weight handling throughout tidymodels. |
23 | | - |
24 | | -## 0.2.0 Submission |
25 | | - |
26 | | -This submission adds a few more `extract_*()` generics, moves `tune()` to hardhat from tune, and fixes a few bugs. |
27 | | - |
28 | | -## 0.1.6 Submission |
29 | | - |
30 | | -This submission adds a new family of `extract_*()` generics for usage in other tidymodels packages. It also formally removes support for logical `indicators` in `default_formula_blueprint()`, which has been soft deprecated for awhile now. |
31 | | - |
32 | | -## 0.1.5 Submission |
33 | | - |
34 | | -This submission adds limited support for sparse matrix output. |
35 | | - |
36 | | -## 0.1.4 Submission |
37 | | - |
38 | | -This submission tweaks the `indicators` argument of `default_formula_blueprint()` to allow for one hot encoding. It also fixes a small bug with character columns. |
39 | | - |
40 | | -## 0.1.3 Submission |
41 | | - |
42 | | -This submission keeps hardhat up to date with vctrs 0.3.0 and fixes a few bugs |
43 | | -regarding novel factor levels. |
44 | | - |
45 | | -## 0.1.2 Submission |
46 | | - |
47 | | -This submission fixes a `stringsAsFactors` note and slightly tweaks how recipes are preprocessed. |
48 | | - |
49 | | -## 0.1.1 Submission |
50 | | - |
51 | | -This submission fixes the test error from the new recipes 0.1.8 update. |
52 | | - |
53 | | -## 0.1.0 Resubmission |
54 | | - |
55 | | -### Review 3 - 2019-12-06 |
56 | | - |
57 | | -> You have examples for unexported functions which cannot run in this way. |
58 | | -Please either add hardhat::: to the function calls in the examples, omit |
59 | | -these examples or export these functions. e.g. scream(), shrink(), in |
60 | | -scream.Rd and shrink.Rd |
61 | | - |
62 | | -Both `scream()` and `shrink()` are already exported, and their help files do not use any unexported functions. |
63 | | - |
64 | | -> \dontrun{} should only be used if the example really cannot be executed |
65 | | -(e.g. because of missing additional software, missing API keys, ...) by |
66 | | -the user. That's why wrapping examples in \dontrun{} adds the comment |
67 | | -("# Not run:") as a warning for the user. |
68 | | -Does not seem necessary. |
69 | | -Please unwrap the examples if they are executable in < 5 sec, or replace |
70 | | -\dontrun{} with \donttest{}. |
71 | | - |
72 | | -Removed all uses of `\dontrun{}`. |
73 | | - |
74 | | -> Please add \value to .Rd files regarding exported methods and explain |
75 | | -the functions results in the documentation. |
76 | | -(See: Writing R Extensions |
77 | | -<https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Documenting-functions> |
78 | | -) |
79 | | -If a function does not return a value, please document that too, e.g. |
80 | | -\value{None}. |
81 | | - |
82 | | -Added return value descriptions for all exported functions. |
83 | | - |
84 | | -### Review 2 - 2019-11-28 |
85 | | - |
86 | | -> Please omit the redundant 'Toolkit for' from your title. |
87 | | -
|
88 | | -Changed the Title from "A Toolkit for the Construction of Modeling Packages" to "Construct Modeling Packages". |
89 | | - |
90 | | -> The Description field is intended to be a (one paragraph) description |
91 | | -of what the package does and why it may be useful. Please elaborate. |
92 | | - |
93 | | -Changed the Description from: |
94 | | - |
95 | | -"Provides infrastructure for building new modeling packages, including functionality around preprocessing, predicting, and validating input." |
96 | | - |
97 | | -to: |
98 | | - |
99 | | -"Building modeling packages is hard. A large amount of effort generally goes into providing an implementation for a new method that is efficient, fast, and correct, but often less emphasis is put on the user interface. A good interface requires specialized knowledge about S3 methods and formulas, which the average package developer might not have. The goal of 'hardhat' is to reduce the burden around building new modeling packages by providing functionality for preprocessing, predicting, and validating input." |
100 | | - |
101 | | -> If there are references describing (the theoretical backgrounds of) the |
102 | | -methods in your package, please add these in the description field of |
103 | | -your DESCRIPTION file in the form |
104 | | -authors (year) <doi:...> |
105 | | -authors (year) <arXiv:...> |
106 | | -authors (year, ISBN:...) |
107 | | -or if those are not available: <https:...> |
108 | | -with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for |
109 | | -auto-linking. |
110 | | - |
111 | | -There are no references for the methods in this package. |
112 | | - |
113 | | -### Review 1 - 2019-11-21 |
114 | | - |
115 | | -> Found the following (possibly) invalid URLs: |
116 | | - URL: https://github.com/tidymodels/hardhat/actions?workflow=R-CMD-check |
117 | | - From: README.md |
118 | | - Status: 404 |
119 | | - Message: Not Found |
120 | | - |
121 | | -Removed invalid URL link as requested. It is valid when signed in to GitHub, |
122 | | -but 404s otherwise. |
| 1 | +There are no expected revdep failures. |
0 commit comments