Small update_visibility optimization

Small update_visibility optimization, does not affect worst case

Author: x753

django/thunderstore/community/models/package_listing.py

@@ -404,6 +404,8 @@ def update_visibility(self):
         By default, listings are visible to everyone (for now). Rejected listings aren't publicly visible,
         and listings with inactive packages aren't visible at all.
         """
+        original_visibility_bitstring = self.visibility.bitstring()
+
         self.visibility.public_detail = True
         self.visibility.public_list = True
         self.visibility.owner_detail = True
@@ -444,7 +446,8 @@ def update_visibility(self):
         if versions.exclude(visibility__moderator_list=False).count() == 0:
             self.visibility.moderator_list = False
 
-        self.visibility.save()
+        if self.visibility.bitstring != original_visibility_bitstring:
+            self.visibility.save()
 
 
 signals.post_save.connect(PackageListing.post_save, sender=PackageListing)

django/thunderstore/permissions/models/visibility.py

@@ -35,3 +35,16 @@ def __str__(self) -> str:
             if isinstance(field, models.BooleanField) and getattr(self, field.name)
         )
         return ", ".join(flag_fields) or "None"
+
+    def bitstring(self) -> str:
+        fields = [
+            self.public_list,
+            self.public_detail,
+            self.owner_list,
+            self.owner_detail,
+            self.moderator_list,
+            self.moderator_detail,
+            self.admin_list,
+            self.admin_detail,
+        ]
+        return "".join("1" if field else "0" for field in fields)

django/thunderstore/repository/models/package.py

@@ -110,8 +110,10 @@ def validate(self):
     def save(self, *args, **kwargs):
         self.validate()
         if self.pk is not None:  # Check if the instance already exists
-            for version in self.versions.all():
-                version.update_visibility()
+            old_instance = Package.objects.get(pk=self.pk)
+            if self.is_active is not old_instance.is_active:
+                for version in self.versions.all():
+                    version.update_visibility()
         return super().save(*args, **kwargs)
 
     def get_or_create_package_listing(self, community):

django/thunderstore/repository/models/package_version.py

@@ -438,6 +438,8 @@ def update_visibility(self):
         By default, versions are visible to everyone (for now). Rejected versions aren't publicly visible,
         and inactive versions or versions with inactive packages aren't visible at all.
         """
+        original_visibility_bitstring = self.visibility.bitstring()
+
         self.visibility.public_detail = True
         self.visibility.public_list = True
         self.visibility.owner_detail = True
@@ -460,10 +462,11 @@ def update_visibility(self):
             self.visibility.public_detail = False
             self.visibility.public_list = False
 
-        self.visibility.save()
-        for listing in self.package.community_listings.all():
-            listing.update_visibility()
-        self.package.recache_latest()
+        if self.visibility.bitstring != original_visibility_bitstring:
+            self.visibility.save()
+            for listing in self.package.community_listings.all():
+                listing.update_visibility()
+            self.package.recache_latest()
 
 
 signals.post_save.connect(PackageVersion.post_save, sender=PackageVersion)