Use binary file read for hashing

Author: cjbarth

tasks/taggers/hash.js

@@ -21,8 +21,8 @@ module.exports = function (src, options) {
 
   src.forEach(function (f) {
     var input = fs.readFileSync(f, options.encoding);
-    hash.update(input);
-    hash.update(f);
+    hash.update(input, 'binary');
+    hash.update(f, 'binary');
   });
 
   var hashLength = parseInt(options.hashLength, 10);

test/assets_versioning_test.js

@@ -242,16 +242,16 @@ exports.assets_versioning = {
     test.equal(versionsMap.length, 4, 'map of versions should contain 4 entities');
 
     test.ok(!grunt.file.exists('tmp/files_expand_format/folder/subfolder/img3.png'), 'should not create an un-versioned img3.png');
-    test.ok(grunt.file.exists('tmp/files_expand_format/folder/subfolder/img3.39c434c9.png'), 'should create a versioned img3.png');
+    test.ok(grunt.file.exists('tmp/files_expand_format/folder/subfolder/img3.d8deeedb.png'), 'should create a versioned img3.png');
 
     test.ok(!grunt.file.exists('tmp/files_expand_format/img1.png'), 'should not create an un-versioned img1.png');
-    test.ok(grunt.file.exists('tmp/files_expand_format/img1.6d45bfcd.png'), 'should create a versioned img1.png');
+    test.ok(grunt.file.exists('tmp/files_expand_format/img1.64317d28.png'), 'should create a versioned img1.png');
 
     test.ok(!grunt.file.exists('tmp/files_expand_format/img2.jpg'), 'should not create an un-versioned img2.jpg');
-    test.ok(grunt.file.exists('tmp/files_expand_format/img2.cc30b94a.jpg'), 'should create a versioned img2.jpg');
+    test.ok(grunt.file.exists('tmp/files_expand_format/img2.08abdf2a.jpg'), 'should create a versioned img2.jpg');
 
     test.ok(!grunt.file.exists('tmp/files_expand_format/folder/img2.gif'), 'should not create an un-versioned img2.gif');
-    test.ok(grunt.file.exists('tmp/files_expand_format/folder/img2.36ef81a6.gif'), 'should create a versioned img2.gif');
+    test.ok(grunt.file.exists('tmp/files_expand_format/folder/img2.77e84a5f.gif'), 'should create a versioned img2.gif');
 
     test.done();
   },
@@ -313,16 +313,16 @@ exports.assets_versioning = {
     test.equal(versionsMap.length, 4, 'map of versions should contain 4 entities');
 
     test.ok(!grunt.file.exists('tmp/task_files_expand_format/folder/subfolder/img3.png'), 'should not create an un-versioned img3.png');
-    test.ok(grunt.file.exists('tmp/task_files_expand_format/folder/subfolder/img3.39c434c9.png'), 'should create a versioned img3.png');
+    test.ok(grunt.file.exists('tmp/task_files_expand_format/folder/subfolder/img3.d8deeedb.png'), 'should create a versioned img3.png');
 
     test.ok(!grunt.file.exists('tmp/task_files_expand_format/img1.png'), 'should not create an un-versioned img1.png');
-    test.ok(grunt.file.exists('tmp/task_files_expand_format/img1.6d45bfcd.png'), 'should create a versioned img1.png');
+    test.ok(grunt.file.exists('tmp/task_files_expand_format/img1.64317d28.png'), 'should create a versioned img1.png');
 
     test.ok(!grunt.file.exists('tmp/task_files_expand_format/img2.jpg'), 'should not create an un-versioned img2.jpg');
-    test.ok(grunt.file.exists('tmp/task_files_expand_format/img2.cc30b94a.jpg'), 'should create a versioned img2.jpg');
+    test.ok(grunt.file.exists('tmp/task_files_expand_format/img2.08abdf2a.jpg'), 'should create a versioned img2.jpg');
 
     test.ok(!grunt.file.exists('tmp/task_files_expand_format/folder/img2.gif'), 'should not create an un-versioned img2.gif');
-    test.ok(grunt.file.exists('tmp/task_files_expand_format/folder/img2.36ef81a6.gif'), 'should create a versioned img2.gif');
+    test.ok(grunt.file.exists('tmp/task_files_expand_format/folder/img2.77e84a5f.gif'), 'should create a versioned img2.gif');
 
     test.done();
   },

test/expected/output/dict.php

@@ -2,9 +2,9 @@
 class MyDict
 {
   public static $myDict = array(
-    "folder/subfolder/img3.png" => "folder/subfolder/img3.39c434c9.png",
-    "img1.png" => "img1.6d45bfcd.png",
-    "img2.jpg" => "img2.cc30b94a.jpg",
-    "folder/img2.gif" => "folder/img2.36ef81a6.gif",
+    "folder/subfolder/img3.png" => "folder/subfolder/img3.d8deeedb.png",
+    "img1.png" => "img1.64317d28.png",
+    "img2.jpg" => "img2.08abdf2a.jpg",
+    "folder/img2.gif" => "folder/img2.77e84a5f.gif",
   );
 }

test/expected/output/options_output.json

@@ -1 +1 @@
-[{"version":"39c434c9","originalPath":"tmp/options_output/folder/subfolder/img3.png","versionedPath":"tmp/options_output/folder/subfolder/img3.39c434c9.png"},{"version":"6d45bfcd","originalPath":"tmp/options_output/img1.png","versionedPath":"tmp/options_output/img1.6d45bfcd.png"},{"version":"cc30b94a","originalPath":"tmp/options_output/img2.jpg","versionedPath":"tmp/options_output/img2.cc30b94a.jpg"},{"version":"36ef81a6","originalPath":"tmp/options_output/folder/img2.gif","versionedPath":"tmp/options_output/folder/img2.36ef81a6.gif"}]
+[{"version":"d8deeedb","originalPath":"tmp/options_output/folder/subfolder/img3.png","versionedPath":"tmp/options_output/folder/subfolder/img3.d8deeedb.png"},{"version":"64317d28","originalPath":"tmp/options_output/img1.png","versionedPath":"tmp/options_output/img1.64317d28.png"},{"version":"08abdf2a","originalPath":"tmp/options_output/img2.jpg","versionedPath":"tmp/options_output/img2.08abdf2a.jpg"},{"version":"77e84a5f","originalPath":"tmp/options_output/folder/img2.gif","versionedPath":"tmp/options_output/folder/img2.77e84a5f.gif"}]

test/expected/output/options_output_trim.json

@@ -1 +1 @@
-[{"version":"39c434c9","originalPath":"folder/subfolder/img3.png","versionedPath":"folder/subfolder/img3.39c434c9.png"},{"version":"6d45bfcd","originalPath":"img1.png","versionedPath":"img1.6d45bfcd.png"},{"version":"cc30b94a","originalPath":"img2.jpg","versionedPath":"img2.cc30b94a.jpg"},{"version":"36ef81a6","originalPath":"folder/img2.gif","versionedPath":"folder/img2.36ef81a6.gif"}]
+[{"version":"d8deeedb","originalPath":"folder/subfolder/img3.png","versionedPath":"folder/subfolder/img3.d8deeedb.png"},{"version":"64317d28","originalPath":"img1.png","versionedPath":"img1.64317d28.png"},{"version":"08abdf2a","originalPath":"img2.jpg","versionedPath":"img2.08abdf2a.jpg"},{"version":"77e84a5f","originalPath":"folder/img2.gif","versionedPath":"folder/img2.77e84a5f.gif"}]