Focus Lock navigation breaks with multiple tabIndex="-1" wrappers

[siarhei-epam]

Issue Description

When using react-focus-lock, the focus navigation within a dialog breaks when a focusable component that displays the dialog is wrapped in a component with tabIndex="-1", and the component following it is also wrapped in a component with tabIndex="-1".

The focus navigation is not calculated correctly and gets stuck in a loop, returning to the starting component instead of cycling through all focusable elements.

Steps to Reproduce

1. Open the CodeSandbox demo
2. Click the "Open modal 1" button to open the dialog
3. Press "Tab" twice or more
4. Observe that the focus does not move and is stuck in a loop

Expected Behavior

Focus should move in a cycle through all focusable components within the dialog.

Environment

• react-focus-lock version: 2.13.5
• React version: (as specified in the CodeSandbox)

Location of the error

https://github.com/theKashey/focus-lock/blob/ab0a54559ab3db3ce53fbe82fe73abe3475027d1/src/solver.ts#L98

[theKashey]

So problem here is not purely about tabIndex, but about shard pointing to a single element ourside of the "expected sequence". That is breaking logic as it thinks you clicked somewhere and returning focus where it was.

The tabindex causes >1 difference causing this "thinking" as you jump over focusable, but non-tabbable elements.

Solution is to keep only tabbables in "correctedNodes" list which exists to handle similar usecase for radio buttons - https://github.com/theKashey/focus-lock/blob/ab0a54559ab3db3ce53fbe82fe73abe3475027d1/src/solver.ts#L56

[siarhei-epam]

I expect focus movement according to HTML specifications and published on MDN. This means that when sequentially moving the focus when pressing Tab, I should not focus on elements with tabindex="-1".

[stale]

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.

[siarhei-epam]

This issue is relevant and awaits resolution
dependency

[stale]

This issue has been marked as "stale" because there has been no activity for 2 months. If you have any new information or would like to continue the discussion, please feel free to do so. If this issue got buried among other tasks, maybe this message will reignite the conversation. Otherwise, this issue will be closed in 7 days. Thank you for your contributions so far.

[dsv-sergey]

Sorry but it doesn't completed