Skip to content

Commit 9ea9ca5

Browse files
OCM-14780 | test: Fixing id:72514,72526, and filter owner for proxy AMI
1 parent 71fb726 commit 9ea9ca5

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

tests/e2e/cluster_autoscaler_day2_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,8 @@ var _ = Describe("Cluster Autoscaler", ci.Day2, ci.FeatureClusterAutoscaler, fun
229229
Expect(caResponse.Status()).To(Equal(http.StatusNotFound))
230230
})
231231

232-
It("can be validated against HCP cluster - [id:72526]", ci.Medium, func() {
232+
// Delete and create cluster autoscaler are not currently supported for HCP
233+
It("can be validated against HCP cluster - [id:72526]", ci.Medium, ci.Exclude, func() {
233234
if !profileHandler.Profile().IsHCP() {
234235
Skip("Test can run only on Hosted cluster")
235236
}

tests/e2e/hcp_machine_pool_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -839,9 +839,10 @@ var _ = Describe("HCP MachinePool", ci.Day2, ci.FeatureMachinepool, func() {
839839
By("Try to create a nodepool with version < CP version-2")
840840
throttleVersion := fmt.Sprintf("%v.%v.0", currentSemVer.Major(), currentSemVer.Minor()-2)
841841
versions = cms.GetHcpLowerVersions(cms.RHCSConnection, throttleVersion, profileHandler.Profile().GetChannelGroup())
842+
versions = cms.SortVersions(versions)
842843
if len(versions) > 0 {
843844
validateMPArgAgainstErrorSubstrings(mpName, func(args *exec.MachinePoolArgs) {
844-
args.OpenshiftVersion = helper.StringPointer(versions[0].RawID)
845+
args.OpenshiftVersion = helper.StringPointer(versions[len(versions)-1].RawID)
845846
}, "must be no less than 2 minor versions behind the Control Plane version")
846847
} else {
847848
Logger.Info("No version < CP version - 2 found to test against")
@@ -850,7 +851,7 @@ var _ = Describe("HCP MachinePool", ci.Day2, ci.FeatureMachinepool, func() {
850851
By("Try to create a nodepool with not supported version")
851852
validateMPArgAgainstErrorSubstrings(mpName, func(args *exec.MachinePoolArgs) {
852853
args.OpenshiftVersion = helper.StringPointer("4.10.67")
853-
}, "must be greater than the lowest supported version")
854+
}, "must be greater than the minimal supported version")
854855

855856
By("Try to create a nodepool with wrong version")
856857
validateMPArgAgainstErrorSubstrings(mpName, func(args *exec.MachinePoolArgs) {

tests/tf-manifests/aws/proxy/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ locals {
1717

1818
data "aws_ami" "proxy_img" {
1919
most_recent = true
20+
owners = ["amazon"]
2021

2122
filter {
2223
name = "name"

0 commit comments

Comments
 (0)