Skip to content

Show Event don't fired #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tlebreton opened this issue Jun 25, 2018 · 1 comment · May be fixed by #122
Open

Show Event don't fired #93

tlebreton opened this issue Jun 25, 2018 · 1 comment · May be fixed by #122

Comments

@tlebreton
Copy link

Hi all

I just note that the show.datetimepicker event and the toggle.datetimepicker event are not firing.

But the hide.datetimepicker is fired normally.

Maybe i do something bad ...

See jsfiddle
https://jsfiddle.net/agbkdzhv/211/

Thanks for the future correction
@john-adams86
Copy link

I think it's in the condition for omitting change event in the DateTimePicker.prototype._notifyEvent:
//if (e.type === DateTimePicker.Event.CHANGE && e.date && e.date.isSame(e.oldDate) || !e.date && !e.oldDate) {
if (e.type === DateTimePicker.Event.CHANGE && (e.date && e.date.isSame(e.oldDate) || !e.date && !e.oldDate)) {
(the show event doesn't have the date or oldDate params and w/o the added parentheses it trigger the last part of the condition)

clavay added a commit to clavay/bootstrap-3 that referenced this issue Oct 14, 2019
@clavay
Fire show event
7bc434f 
Resolve : tempusdominus#93
@clavay clavay linked a pull request Oct 14, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fire show event clavay/bootstrap-3
2 participants
@john-adams86 @tlebreton