Fail health check if no hosts are available #8345
Merged
+175
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Sep 18, 2025
|
Is it possible to add a unit test? |
deepakkarki
pushed a commit
that referenced
this pull request
Sep 25, 2025
## What changed? Instead of returning healthy, return unhealthy if no hosts available. ## Why? It's a fair assertion that if there are no hosts available, the service is not healthy. ## How did you test it? - [x ] built - [ x] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) ## Potential risks There could be a false positive edge case that I'm not considering, but unlikely.
Merged
temporal-cicd bot
added a commit
that referenced
this pull request
Sep 25, 2025
Patch release 1.29.0 with PR(s): - [#8345](#8345) - [#8368](#8368) --------- Co-authored-by: Lanie Hei <[email protected]> Co-authored-by: Will Duan <[email protected]> Co-authored-by: temporal-cicd[bot] <temporal-cicd[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Instead of returning healthy, return unhealthy if no hosts available.
Why?
It's a fair assertion that if there are no hosts available, the service is not healthy.
How did you test it?
Potential risks
There could be a false positive edge case that I'm not considering, but unlikely.