improve RawValue API

Author: THardy98

packages/common/src/converter/payload-converter.ts

@@ -122,8 +122,12 @@ export class RawValue<T = unknown> {
   private readonly _payload: Payload;
   private readonly [rawPayloadTypeBrand]: T = undefined as T;
 
-  constructor(value: T, payloadConverter: PayloadConverter = defaultPayloadConverter) {
-    this._payload = payloadConverter.toPayload(value);
+  private constructor(payload: Payload) {
+    this._payload = payload;
+  }
+
+  static fromValue<T>(value: T, converter: PayloadConverter = defaultPayloadConverter): RawValue<T> {
+    return new RawValue<T>(converter.toPayload(value));
   }
 
   get payload(): Payload {

packages/test/src/test-integration-workflows.ts

@@ -1320,22 +1320,22 @@ test.serial('can register search attributes to dev server', async (t) => {
 
 export async function rawValueWorkflow(value: unknown): Promise<RawValue> {
   const { rawValueActivity } = workflow.proxyActivities({ startToCloseTimeout: '10s' });
-  return await rawValueActivity(new RawValue(value));
+  return await rawValueActivity(RawValue.fromValue(value));
 }
 
 test('workflow and activity can receive/return RawValue', async (t) => {
   const { executeWorkflow, createWorker } = helpers(t);
   const worker = await createWorker({
     activities: {
       async rawValueActivity(value: unknown): Promise<RawValue> {
-        return new RawValue(value);
+        return RawValue.fromValue(value);
       },
     },
   });
 
   await worker.runUntil(async () => {
     const testValue = 'test';
-    const rawValue = new RawValue(testValue);
+    const rawValue = RawValue.fromValue(testValue);
     const res = await executeWorkflow(rawValueWorkflow, {
       args: [rawValue],
     });

packages/workflow/src/internals.ts

@@ -280,7 +280,7 @@ export class Activator implements ActivationHandler {
       STACK_TRACE_QUERY_NAME,
       {
         handler: () => {
-          return new RawValue<string>(
+          return RawValue.fromValue(
             this.getStackTraces()
               .map((s) => s.formatted)
               .join('\n\n')
@@ -312,7 +312,7 @@ export class Activator implements ActivationHandler {
               }
             }
           }
-          return new RawValue<EnhancedStackTrace>({ sdk, stacks, sources });
+          return RawValue.fromValue({ sdk, stacks, sources });
         },
         description: 'Returns a stack trace annotated with source information.',
       },
@@ -334,7 +334,7 @@ export class Activator implements ActivationHandler {
             name,
             description: value.description,
           }));
-          return new RawValue<temporal.api.sdk.v1.IWorkflowMetadata>({
+          return RawValue.fromValue({
             definition: {
               type: workflowType,
               queryDefinitions,