Content library #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolbung
reviewed
May 17, 2019
| } | ||
|
|
||
| getArticle(apiBaseUrl, article_alias) { | ||
| const url = apiBaseUrl + 'index.php?option=com_api&app=articles&resource=article&format=raw&article_alias=' + article_alias; |
Member
There was a problem hiding this comment.
Move this to the top of the class, not in this method.
The base URL should be injected into this component via the module config cc @sudhir-j-sapkal @Pratikshakhandagale
Pratikshakhandagale
referenced
this pull request
in Pratikshakhandagale/ngtek-joomla
May 20, 2019
Content List and Blog view
Member
|
Needs to be updated. Has merge conflicts. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display Joomla Article on Angular