Skip dynamic entity class names in NoGetRepositoryOutsideServiceRule

Author: TomasVotruba

src/Rules/Doctrine/NoGetRepositoryOutsideServiceRule.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Scalar\String_;
 use PHPStan\Analyser\Scope;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -34,10 +35,18 @@ public function getNodeType(): string
      */
     public function processNode(Node $node, Scope $scope): array
     {
+        if ($node->isFirstClassCallable()) {
+            return [];
+        }
+
         if (! NamingHelper::isName($node->name, 'getRepository')) {
             return [];
         }
 
+        if ($this->isDynamicArg($node)) {
+            return [];
+        }
+
         if (! $scope->isInClass()) {
             $ruleError = RuleErrorBuilder::message(self::ERROR_MESSAGE)
                 ->identifier(DoctrineRuleIdentifier::NO_GET_REPOSITORY_OUTSIDE_SERVICE)
@@ -58,4 +67,14 @@ public function processNode(Node $node, Scope $scope): array
 
         return [$ruleError];
     }
+
+    private function isDynamicArg(MethodCall $methodCall): bool
+    {
+        $firstArg = $methodCall->getArgs()[0];
+        if ($firstArg->value instanceof String_) {
+            return false;
+        }
+
+        return ! $firstArg->value instanceof Node\Expr\ClassConstFetch;
+    }
 }

tests/Rules/Doctrine/NoGetRepositoryOutsideServiceRule/Fixture/GetRepositoryRandomEntity.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\Doctrine\NoGetRepositoryOutsideServiceRule\Fixture;
+
+use Doctrine\ORM\EntityManager;
+use Symplify\PHPStanRules\Tests\Rules\Doctrine\NoGetRepositoryOutsideServiceRule\Source\SomeRandomEntity;
+
+final readonly class GetRepositoryRandomEntity
+{
+    public function __construct(
+        private EntityManager $entityManager
+    ) {
+    }
+
+    public function run(): void
+    {
+        $someRepository = $this->entityManager->getRepository(SomeRandomEntity::class);
+    }
+}

tests/Rules/Doctrine/NoGetRepositoryOutsideServiceRule/Fixture/SkipDymamicFetch.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symplify\PHPStanRules\Tests\Rules\Doctrine\NoGetRepositoryOutsideServiceRule\Fixture;
+
+use Doctrine\ORM\EntityManager;
+use Symplify\PHPStanRules\Tests\Rules\Doctrine\NoGetRepositoryOutsideServiceRule\Source\SomeRandomEntity;
+
+final readonly class SkipDymamicFetch
+{
+    public function run(
+        EntityManager $entityManager,
+        string $className
+    ) {
+        $someRepository = $entityManager->getRepository($className);
+    }
+}

tests/Rules/Doctrine/NoGetRepositoryOutsideServiceRule/NoGetRepositoryOutsideServiceRuleTest.php

@@ -28,7 +28,13 @@ public static function provideData(): Iterator
             18,
         ]]];
 
+        yield [__DIR__ . '/Fixture/GetRepositoryRandomEntity.php', [[
+            NoGetRepositoryOutsideServiceRule::ERROR_MESSAGE,
+            19,
+        ]]];
+
         yield [__DIR__ . '/Fixture/SkipInRepository.php', []];
+        yield [__DIR__ . '/Fixture/SkipDymamicFetch.php', []];
     }
 
     protected function getRule(): Rule