Skip to content

fix: prevent memory leaking signals in legacy mode #16145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2025

Conversation

7nik
Copy link
Contributor

@7nik 7nik commented Jun 13, 2025

Closes #16040

Alternative to #16141

Looks like there is no need for tracking these signals, they just need to use safe_equals equality check.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 13, 2025

🦋 Changeset detected

Latest commit: f2e61f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16145

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

@Rich-Harris Rich-Harris merged commit 6636f74 into main Jun 14, 2025
14 checks passed
@Rich-Harris Rich-Harris deleted the fix-memory-leaking-signals branch June 14, 2025 15:19
@github-actions github-actions bot mentioned this pull request Jun 14, 2025
@paoloricciuti
Copy link
Member

Wait I was sure I left a comment here but apparently I did not: if your item is an object and you mutate it before update needs to be invoked...this currently doesn't work so dunno if we want to make it work but technically it works in svelte 4

@Rich-Harris
Copy link
Member

do you have a repro?

@paoloricciuti
Copy link
Member

paoloricciuti commented Jun 14, 2025

Yup: this works and invoke before update in svelte 4 but doesn't work in svelte 5 legacy mode (and it will definitely not invoke before after this change.

Same for an each block where the item is an object

@7nik
Copy link
Contributor Author

7nik commented Jun 14, 2025

I've looked in that case, and think there, like in #each in case of mutation, should be invoked invalidate_inner_signals. But using it requests a bunch of metadata that the #await block currently lacks.

@paoloricciuti
Copy link
Member

Tbf I don't think anyone is relying on this behavior so we could just decide this is fine

@Rich-Harris
Copy link
Member

Yeah, there'd be no harm in fixing it but since this PR doesn't introduce a new bug and since it's likely that no-one relies on the Svelte 4 behaviour I'm inclined to ignore it

@github-actions github-actions bot mentioned this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key+each blocks leaking memory in legacy mode
3 participants