Skip to content

Clarification: future of network feature in sdk crate #2484

@citizen-stig

Description

@citizen-stig

There's a TODO comment:

# TODO: Once alloy has a 1.* release, we can likely remove this feature flag, as there will be less
# dependency resolution issues.
network = [
"dep:prost",
"dep:alloy-signer",
"dep:alloy-signer-aws",

Which has been added in this PR #850

But specified alloy versions already 1.0, which was updated here #2309

alloy-signer = { version = "1.0", default-features = false, optional = true }
alloy-signer-aws = { version = "1.0", default-features = false, optional = true }
alloy-signer-local = { version = "1.0", default-features = false, optional = true }
alloy-sol-types = { version = "1.0", default-features = false }
alloy-primitives = { version = "1.0", default-features = false, optional = true, features = [

Question is Would network feature remain?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions