Copy hover response content and diagnostics text from the hover popup

boot.py

@@ -56,6 +56,7 @@
 from .plugin.hierarchy import LspCallHierarchyCommand
 from .plugin.hierarchy import LspHierarchyToggleCommand
 from .plugin.hierarchy import LspTypeHierarchyCommand
+from .plugin.hover import LspCopyTextCommand
 from .plugin.hover import LspHoverCommand
 from .plugin.hover import LspToggleHoverPopupsCommand
 from .plugin.inlay_hint import LspInlayHintClickCommand
@@ -100,6 +101,7 @@
     "LspCollapseTreeItemCommand",
     "LspColorPresentationCommand",
     "LspCommitCompletionWithOppositeInsertMode",
+    "LspCopyTextCommand",
     "LspCopyToClipboardFromBase64Command",
     "LspDisableLanguageServerGloballyCommand",
     "LspDisableLanguageServerInProjectCommand",

plugin/completion.py

@@ -3,13 +3,13 @@
 from .core.edit import apply_text_edits
 from .core.logging import debug
 from .core.promise import Promise
-from .core.protocol import EditRangeWithInsertReplace
 from .core.protocol import CompletionItem
 from .core.protocol import CompletionItemDefaults
 from .core.protocol import CompletionItemKind
 from .core.protocol import CompletionItemTag
 from .core.protocol import CompletionList
 from .core.protocol import CompletionParams
+from .core.protocol import EditRangeWithInsertReplace
 from .core.protocol import Error
 from .core.protocol import InsertReplaceEdit
 from .core.protocol import InsertTextFormat
@@ -20,6 +20,7 @@
 from .core.registry import LspTextCommand
 from .core.sessions import Session
 from .core.settings import userprefs
+from .core.views import copy_text_html
 from .core.views import FORMAT_STRING, FORMAT_MARKUP_CONTENT
 from .core.views import MarkdownLangMap
 from .core.views import minihtml
@@ -303,9 +304,10 @@ def _handle_resolve_response_async(self, language_map: MarkdownLangMap | None, i
             documentation = self._format_documentation(markdown, None)
         minihtml_content = ""
         if detail:
-            minihtml_content += f"<div class='highlight'>{detail}</div>"
+            minihtml_content += copy_text_html(f"<div class='highlight'>{detail}</div>",
+                                               copy_text=item.get('detail') or "")
         if documentation:
-            minihtml_content += documentation
+            minihtml_content += copy_text_html(documentation, copy_text=item.get("documentation") or "")
 
         def run_main() -> None:
             if not self.view.is_valid():
@@ -330,7 +332,8 @@ def _format_documentation(
         return minihtml(self.view, content, FORMAT_STRING | FORMAT_MARKUP_CONTENT, language_map)
 
     def _on_navigate(self, url: str) -> None:
-        webbrowser.open(url)
+        if url.startswith("http"):
+            webbrowser.open(url)
 
 
 class LspCommitCompletionWithOppositeInsertMode(LspTextCommand):

plugin/core/signature_help.py

@@ -3,6 +3,7 @@
 from .protocol import SignatureHelp
 from .protocol import SignatureInformation
 from .registry import LspTextCommand
+from .views import copy_text_html
 from .views import FORMAT_MARKUP_CONTENT
 from .views import FORMAT_STRING
 from .views import MarkdownLangMap
@@ -83,7 +84,7 @@ def render(self, view: sublime.View) -> str:
         else:
             self._active_parameter_bold = active_parameter_style.get('bold', False)
             self._active_parameter_underline = active_parameter_style.get('underline', False)
-        formatted.extend(self._render_label(signature))
+        formatted.append(self._render_label(signature))
         formatted.extend(self._render_docs(view, signature))
         return "".join(formatted)
 
@@ -111,7 +112,7 @@ def _render_intro(self) -> str:
             len(self._signatures),
         )
 
-    def _render_label(self, signature: SignatureInformation) -> list[str]:
+    def _render_label(self, signature: SignatureInformation) -> str:
         formatted: list[str] = []
         # Note that this <div> class and the extra <pre> are copied from mdpopups' HTML output. When mdpopups changes
         # its output style, we must update this literal string accordingly.
@@ -147,7 +148,7 @@ def _render_label(self, signature: SignatureInformation) -> list[str]:
         else:
             formatted.append(self._function(label))
         formatted.append("</pre></div>")
-        return formatted
+        return copy_text_html("".join(formatted), label)
 
     def _render_docs(self, view: sublime.View, signature: SignatureInformation) -> list[str]:
         formatted: list[str] = []
@@ -175,14 +176,16 @@ def _parameter_documentation(self, view: sublime.View, signature: SignatureInfor
         documentation = parameter.get("documentation")
         if documentation:
             allowed_formats = FORMAT_STRING | FORMAT_MARKUP_CONTENT
-            return minihtml(view, documentation, allowed_formats, self._language_map)
+            return copy_text_html(minihtml(view, documentation, allowed_formats, self._language_map),
+                                  copy_text=documentation)
         return None
 
     def _signature_documentation(self, view: sublime.View, signature: SignatureInformation) -> str | None:
         documentation = signature.get("documentation")
         if documentation:
             allowed_formats = FORMAT_STRING | FORMAT_MARKUP_CONTENT
-            return minihtml(view, documentation, allowed_formats, self._language_map)
+            return copy_text_html(minihtml(view, documentation, allowed_formats, self._language_map),
+                                  copy_text=documentation)
         return None
 
     def _function(self, content: str) -> str:

plugin/core/views.py

@@ -820,9 +820,9 @@ def _html_element(name: str, text: str, class_name: str | None = None, escape: b
 
 
 def format_diagnostic_for_html(config: ClientConfig, diagnostic: Diagnostic, base_dir: str | None = None) -> str:
-    html = _html_element('span', diagnostic["message"])
     code = diagnostic.get("code")
-    source = diagnostic.get("source")
+    source = diagnostic.get("source") or ""
+    html = _html_element('span', diagnostic["message"])
     if source or code is not None:
         meta_info = ""
         if source:
@@ -832,14 +832,38 @@ def format_diagnostic_for_html(config: ClientConfig, diagnostic: Diagnostic, bas
             meta_info += "({})".format(
                 make_link(code_description["href"], str(code)) if code_description else text2html(str(code)))
         html += " " + _html_element("span", meta_info, class_name="color-muted", escape=False)
+    html = copy_text_html(html, copy_text=f"{source} {diagnostic['message']}")
     related_infos = diagnostic.get("relatedInformation")
     if related_infos:
-        info = "<br>".join(_format_diagnostic_related_info(config, info, base_dir) for info in related_infos)
+        info = "<br>".join(copy_text_html(
+            _format_diagnostic_related_info(config, info, base_dir),
+            copy_text=info['message']
+        ) for info in related_infos)
         html += '<br>' + _html_element("pre", info, class_name="related_info", escape=False)
     severity_class = DIAGNOSTIC_SEVERITY[diagnostic_severity(diagnostic) - 1][1]
     return _html_element("pre", html, class_name=severity_class, escape=False)
 
 
+def copy_text_html(html_content: str, copy_text: str | MarkupContent | MarkedString | list[MarkedString]) -> str:
+    copy_text = _markup_to_string(copy_text)
+    if not len(copy_text):
+        return html_content
+    return f"""<a title="Click to Copy"
+       style='text-decoration: none; display: block; color: inherit'
+       href='{sublime.command_url('lsp_copy_text', {
+        'text': copy_text
+       })}'>{html_content}</a>"""
+
+
+def _markup_to_string(content: MarkupContent | MarkedString | list[MarkedString]) -> str:
+    if isinstance(content, str):
+        return content
+    if isinstance(content, dict):
+        return content.get('value', '')
+    if isinstance(content, list):
+        return " ".join([_markup_to_string(text) for text in content])
+
+
 def format_code_actions_for_quick_panel(
     session_actions: Iterable[tuple[str, CodeAction | Command]]
 ) -> tuple[list[sublime.QuickPanelItem], int]:

plugin/documents.py

@@ -729,7 +729,8 @@ def _on_sighelp_hide(self) -> None:
         self._sighelp = None
 
     def _on_sighelp_navigate(self, href: str) -> None:
-        webbrowser.open_new_tab(href)
+        if href.startswith("http"):
+            webbrowser.open_new_tab(href)
 
     # --- textDocument/codeAction --------------------------------------------------------------------------------------
 

plugin/hover.py

@@ -23,6 +23,7 @@
 from .core.sessions import SessionBufferProtocol
 from .core.settings import userprefs
 from .core.url import parse_uri
+from .core.views import copy_text_html
 from .core.views import diagnostic_severity
 from .core.views import format_code_actions_for_quick_panel
 from .core.views import format_diagnostic_for_html
@@ -46,7 +47,6 @@
 import sublime
 import sublime_plugin
 
-
 SessionName = str
 ResolvedHover = Union[Hover, Error]
 
@@ -259,11 +259,13 @@ def diagnostics_content(self) -> str:
         return "".join(formatted)
 
     def hover_content(self) -> str:
-        contents = []
+        contents: list[str] = []
         for hover, language_map in self._hover_responses:
             content = (hover.get('contents') or '') if isinstance(hover, dict) else ''
             allowed_formats = FORMAT_MARKED_STRING | FORMAT_MARKUP_CONTENT
-            contents.append(minihtml(self.view, content, allowed_formats, language_map))
+            html_content = copy_text_html(minihtml(self.view, content, allowed_formats, language_map),
+                                          copy_text=content)
+            contents.append(html_content)
         return '<hr>'.join(contents)
 
     def hover_range(self) -> sublime.Region | None:
@@ -420,3 +422,10 @@ def _update_views_async(self, enable: bool) -> None:
                     session_view.view.settings().set(SHOW_DEFINITIONS_KEY, False)
                 else:
                     session_view.reset_show_definitions()
+
+
+class LspCopyTextCommand(sublime_plugin.TextCommand):
+    def run(self, edit, text: str) -> None:
+        sublime.set_clipboard(text)
+        text_length = len(text)
+        sublime.status_message(f"Copied {text_length} character{'s' if text_length > 1 else ''}")

tests/test_signature_help.py

@@ -44,14 +44,22 @@ def test_signature(self) -> None:
                 "activeParameter": 0
             },
             r'''
+            <a[^>]+>
             <div class="highlight"><pre>
             <span style="color: #\w{6}">f\(</span>
             <span style="color: #\w{6}; font-weight: bold; text-decoration: underline">x</span>
             <span style="color: #\w{6}">\)</span>
             </pre></div>
+            </a>
+            <a[^>]+>
             <p>must be in the frobnicate range</p>
+            </a>
             <hr/>
-            <div style="font-size: 0\.9rem"><p>f does interesting things</p></div>
+            <div style="font-size: 0\.9rem">
+            <a[^>]+>
+            <p>f does interesting things</p>
+            </a>
+            </div>
             '''
         )
 
@@ -84,14 +92,22 @@ def test_markdown(self) -> None:
                 "activeParameter": 0
             },
             r'''
+            <a[^>]+>
             <div class="highlight"><pre>
             <span style="color: #\w{6}">f\(</span>
             <span style="color: #\w{6}; font-weight: bold; text-decoration: underline">x</span>
             <span style="color: #\w{6}">\)</span>
             </pre></div>
+            </a>
+            <a[^>]+>
             <p>must be in the <strong>frobnicate</strong> range</p>
+            </a>
             <hr/>
-            <div style="font-size: 0\.9rem"><p>f does <em>interesting</em> things</p></div>
+            <div style="font-size: 0\.9rem">
+            <a[^>]+>
+            <p>f does <em>interesting</em> things</p>
+            </a>
+            </div>
             '''
         )
 
@@ -118,14 +134,18 @@ def test_second_parameter(self) -> None:
                 "activeParameter": 1
             },
             r'''
+            <a[^>]+>
             <div class="highlight"><pre>
             <span style="color: #\w{6}">f\(</span>
             <span style="color: #\w{6}">x</span>
             <span style="color: #\w{6}">, </span>
             <span style="color: #\w{6}; font-weight: bold; text-decoration: underline">y</span>
             <span style="color: #\w{6}">\)</span>
             </pre></div>
+            </a>
+            <a[^>]+>
             <p>hello there</p>
+            </a>
             '''
         )
 
@@ -152,14 +172,18 @@ def test_parameter_ranges(self) -> None:
                 "activeParameter": 1
             },
             r'''
+            <a[^>]+>
             <div class="highlight"><pre>
             <span style="color: #\w{6}">f\(</span>
             <span style="color: #\w{6}">x</span>
             <span style="color: #\w{6}">, </span>
             <span style="color: #\w{6}; font-weight: bold; text-decoration: underline">y</span>
             <span style="color: #\w{6}">\)</span>
             </pre></div>
+            </a>
+            <a[^>]+>
             <p>hello there</p>
+            </a>
             '''
         )
 
@@ -206,6 +230,7 @@ def test_overloads(self) -> None:
             <b>2</b> of <b>2</b> overloads \(use <kbd>↑</kbd> <kbd>↓</kbd> to navigate, press <kbd>Esc</kbd> to hide\):
             </div>
             </p>
+            <a[^>]+>
             <div class="highlight"><pre><span style="color: #\w{6}">f\(</span>
             <span style="color: #\w{6}; font-weight: bold; text-decoration: underline">x</span>
             <span style="color: #\w{6}">, </span>
@@ -214,6 +239,7 @@ def test_overloads(self) -> None:
             <span style="color: #\w{6}">b</span>
             <span style="color: #\w{6}">\)</span>
             </pre></div>
+            </a>
             '''
         )
 
@@ -238,7 +264,7 @@ def test_dockerfile_signature(self) -> None:
                 "activeParameter": 2
             },
             r'''
-            <div class="highlight"><pre>
+            <a[^>]+><div class="highlight"><pre>
             <span style="color: #\w{6}">RUN </span>
             <span style="color: #\w{6}">\[</span>
             <span style="color: #\w{6}"> </span>
@@ -250,5 +276,6 @@ def test_dockerfile_signature(self) -> None:
             <span style="color: #\w{6}"> </span>
             <span style="color: #\w{6}">\]</span>
             </pre></div>
+            </a>
             '''
         )