Enable Link based on link_mode value
#5545
Draft
+86
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/link-enabled-based-on-link-mode
branch
from
4229b0c to
1131dc7
Compare
StripePayments- public var allResponseFields: [Swift.AnyHashable : Any] {
- get
- }
- public var allResponseFields: [Swift.AnyHashable : Any] {
- get
- }
- public var allResponseFields: [Swift.AnyHashable : Any] {
- get
- }If you are adding a new public API consider the following:
If you are modifying or removing a public API:
If you confirm these APIs need to be added/updated and have undergone necessary review, add the label ℹ️ If this comment appears to be left in error, make sure your branch is up-to-date with |
tillh-stripe
force-pushed
the
tillh/link-enabled-based-on-link-mode
branch
4 times, most recently
from
3c9ac10 to
9008ed9
Compare
tillh-stripe
force-pushed
the
tillh/link-enabled-based-on-link-mode
branch
2 times, most recently
from
7af64a4 to
15acd4b
Compare
tillh-stripe
commented
Sep 29, 2025
|
|
||
| private func updatePaymentMethodDetail(data: Data, variables: [String: String]) -> Data { | ||
| var template = String(decoding: data, as: UTF8.self) | ||
| var template = String(data: data, encoding: .utf8)! |
There was a problem hiding this comment.
Drive-by fix.
tillh-stripe
commented
Sep 29, 2025
| ) | ||
| presentPaymentSheet(darkMode: false) | ||
| verify(paymentSheet.bottomSheetViewController.view!) | ||
| UserDefaults.standard.removeObject(forKey: "FINANCIAL_CONNECTIONS_INSTANT_DEBITS_INCENTIVES") |
There was a problem hiding this comment.
This test started failing, and I assume it's because we never reset the value after enabling it at the start of the test.
tillh-stripe
commented
Sep 29, 2025
| } | ||
|
|
||
| func testPromoBadgeInFormTitle() { | ||
| UserDefaults.standard.setValue(true, forKey: "FINANCIAL_CONNECTIONS_INSTANT_DEBITS_INCENTIVES") |
tillh-stripe
commented
Sep 29, 2025
| externalPaymentMethodTypes: [String] = [], | ||
| customerSessionData: [String: Any]? = nil, | ||
| cardBrandChoiceData: [String: Any]? = nil, | ||
| isLinkPassthroughModeEnabled: Bool? = nil, |
There was a problem hiding this comment.
Removing this parameter, as the link_mode determines the passthrough state. Added logic below so that link_settings.link_passthrough_mode_enabled is still set correctly.
tillh-stripe
force-pushed
the
tillh/link-enabled-based-on-link-mode
branch
from
a6e3672 to
56d82dd
Compare
tillh-stripe
force-pushed
the
tillh/link-enabled-based-on-link-mode
branch
from
56d82dd to
08c931d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates
STPElementsSession.supportsLinkto only consider thelinkSettings.linkModevalue, as opposed to looking at theorderedPaymentMethodTypesandlinkPassthroughModeEnabled.Motivation
Be in line with Web and simplify future backend changes.
Testing
Updated tests and test structs.
Changelog