Add toggle to disable muted notifications (#5517)

Author: gettinToasty

app/components-react/root/StudioEditor.tsx

@@ -28,6 +28,7 @@ export default function StudioEditor() {
     AudioService,
     NotificationsService,
     JsonrpcService,
+    DefaultHardwareService,
   } = Services;
   const performanceMode = useRealmObject(CustomizationService.state).performanceMode;
   const v = useVuex(() => ({
@@ -64,6 +65,7 @@ export default function StudioEditor() {
     const subscription = AudioService.audioNotificationUpdated.subscribe(notificationType => {
       if (timeoutHandles[notificationType]) return;
       if (!StreamingService.views.isStreaming && !StreamingService.views.isRecording) return;
+      if (!DefaultHardwareService.state.enableMuteNotifications) return;
 
       timeoutHandles[notificationType] = setTimeout(() => {
         timeoutHandles[notificationType] = undefined;

app/components-react/windows/advanced-audio/GlobalSettings.tsx

@@ -19,7 +19,7 @@ const trackOptions = [
 ];
 
 export default function GlobalSettings() {
-  const { SettingsService, UserService, StreamingService } = Services;
+  const { SettingsService, UserService, StreamingService, DefaultHardwareService } = Services;
 
   const {
     advancedAudioSettings,
@@ -33,6 +33,7 @@ export default function GlobalSettings() {
     isStreaming,
     isRecording,
     isMultiStreaming,
+    enableMuteNotifications,
   } = useVuex(() => ({
     advancedAudioSettings: SettingsService.views.advancedAudioSettings,
     isAdvancedOutput: SettingsService.views.isAdvancedOutput,
@@ -45,6 +46,7 @@ export default function GlobalSettings() {
     isStreaming: StreamingService.views.isStreaming,
     isRecording: StreamingService.views.isRecording,
     isMultiStreaming: StreamingService.views.isMultiplatformMode,
+    enableMuteNotifications: DefaultHardwareService.state.enableMuteNotifications,
   }));
 
   const monitoringDevice = advancedAudioSettings?.parameters.find(
@@ -69,6 +71,10 @@ export default function GlobalSettings() {
     SettingsService.actions.setSettingValue('Output', type, value);
   }
 
+  function handleToggleMuteNotifications() {
+    DefaultHardwareService.actions.toggleMuteNotifications();
+  }
+
   const shouldShowTwitchVODTrack = isAdvancedOutput && isTwitchAuthedAndActive && !isMultiStreaming;
 
   return (
@@ -147,6 +153,11 @@ export default function GlobalSettings() {
             </div>
           </InputWrapper>
         )}
+        <SwitchInput
+          label={$t('Enable Muted Notifications')}
+          value={enableMuteNotifications}
+          onChange={handleToggleMuteNotifications}
+        />
       </ObsSettingsSection>
 
       <ObsSettings page="Audio" />

app/i18n/en-US/audio.json

@@ -43,5 +43,6 @@
   "Mic/Auxiliary Device 1": "Mic/Auxiliary Device 1",
   "Mic/Auxiliary Device 2": "Mic/Auxiliary Device 2",
   "Mic/Auxiliary Device 3": "Mic/Auxiliary Device 3",
-  "Recording Audio Encoder": "Recording Audio Encoder"
+  "Recording Audio Encoder": "Recording Audio Encoder",
+  "Enable Muted Notifications": "Enable Muted Notifications"
 }

app/services/hardware/default-hardware.ts

@@ -11,13 +11,18 @@ interface IDefaultHardwareServiceState {
   defaultVideoDevice: string;
   defaultAudioDevice: string;
   presetFilter: string;
+  // TODO: This is probably more appropriate in the audio settings service once
+  // that gets moved to the new API and we store FE settings but this is the closest
+  // PersistentStatefulService I could find
+  enableMuteNotifications: boolean;
 }
 
 export class DefaultHardwareService extends PersistentStatefulService<IDefaultHardwareServiceState> {
   static defaultState: IDefaultHardwareServiceState = {
     defaultVideoDevice: null,
     defaultAudioDevice: 'default',
     presetFilter: '',
+    enableMuteNotifications: true,
   };
 
   @Inject() private hardwareService: HardwareService;
@@ -167,6 +172,10 @@ export class DefaultHardwareService extends PersistentStatefulService<IDefaultHa
     }
   }
 
+  toggleMuteNotifications() {
+    this.SET_ENABLE_MUTE_NOTIFICATIONS(!this.state.enableMuteNotifications);
+  }
+
   @mutation()
   private SET_DEVICE(type: string, id: string) {
     if (type === 'video') {
@@ -180,4 +189,9 @@ export class DefaultHardwareService extends PersistentStatefulService<IDefaultHa
   private SET_PRESET_FILTER(filter: string) {
     this.state.presetFilter = filter;
   }
+
+  @mutation()
+  private SET_ENABLE_MUTE_NOTIFICATIONS(val: boolean) {
+    this.state.enableMuteNotifications = val;
+  }
 }