Add InstallSlitherAnalyzerAsync method.

Author: allisterb

src/Stratis.VS.StratisEVM/StratisEVMPackage.cs

@@ -148,7 +148,8 @@ protected override async Task InitializeAsync(CancellationToken cancellationToke
 
             await TaskScheduler.Default;
             await InstallBuildSystemAsync();
-            
+            await InstallSlitherAnalyzerAsync();
+
             await JoinableTaskFactory.SwitchToMainThreadAsync();
             ApplicationThemeManager.Apply(UI.VSTheme.ApplicationThemeGuess);
             await SolidityProjectMenuCommands.InitializeAsync(this);
@@ -161,7 +162,7 @@ protected override async Task InitializeAsync(CancellationToken cancellationToke
         #endregion
 
         #region Static Methods
-        public static async Task InstallBuildSystemAsync()
+        private static async Task InstallBuildSystemAsync()
         {
 #if DEBUG
             await Runtime.CopyDirectoryAsync(Runtime.AssemblyLocation.CombinePath("BuildSystem"), Runtime.LocalAppDataDir.CombinePath("CustomProjectSystems", "Solidity"), true);
@@ -194,6 +195,22 @@ public static async Task InstallBuildSystemAsync()
             await File.WriteAllTextAsync(Runtime.LocalAppDataDir.CombinePath("CustomProjectSystems", "Solidity", "extdir.txt"), Runtime.AssemblyLocation);
         }
 
+        private static async Task InstallSlitherAnalyzerAsync()
+        {
+            if (!File.Exists(Runtime.AssemblyLocation.CombinePath(SlitherExe)))
+            {
+                if (!await Runtime.DownloadFileAsync("slither", new Uri("https://ajb.nyc3.cdn.digitaloceanspaces.com/stratisdevex/slither-0.10.3.exe"), Runtime.AssemblyLocation.CombinePath(SlitherExe)))
+                {
+                    Runtime.Error("Could not download Slither executable.");
+                    return;
+                }
+            }
+            if (!File.Exists(Runtime.LocalAppDataDir.CombinePath("CustomProjectSystems", "Solidity", "Tools", SlitherExe)))
+            {
+                await Runtime.CopyFileAsync(Runtime.AssemblyLocation.CombinePath(SlitherExe), Runtime.LocalAppDataDir.CombinePath("CustomProjectSystems", "Solidity", "Tools", SlitherExe));
+            }
+        }
+
         private void InstallSolidityProjectDataFlowSinks(UnconfiguredProject unconfiguredProject)
         {
             var subscriptionService = unconfiguredProject.Services.ActiveConfiguredProjectSubscription;
@@ -222,6 +239,8 @@ private void InstallSolidityProjectDataFlowSinks(UnconfiguredProject unconfigure
         public const string SolidityProjectFileUIContextRule = "9d4c64d4-52eb-4ebe-aa01-1d975eb3a9d7";
 
         public const string NPMFileUIContextRule = "9A7CA75A-FA6E-45B2-B6E9-4BFF0AB7BB88";
+
+        public const string SlitherExe = "slither-0.10.3.exe";
         #endregion
 
     }

src/Stratis.VS.StratisEVM/UI/BlockchainExplorer/BlockchainExplorerToolWindowControl.xaml.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Windows.Documents;
 using System.IO;
 using System.Security.Cryptography;
 using System.Linq;
@@ -18,11 +19,11 @@
 using Wpc = Wpf.Ui.Controls;
 using Nethereum.Util;
 
-using static Stratis.DevEx.Result;
+using Stratis.DevEx;
 using Stratis.DevEx.Ethereum;
 using Stratis.VS.StratisEVM.UI.ViewModel;
-using Stratis.DevEx;
-using System.Windows.Documents;
+using static Stratis.DevEx.Result;
+using Nethereum.Hex.HexTypes;
 
 namespace Stratis.VS.StratisEVM.UI
 {
@@ -923,7 +924,7 @@ private async void RunContractCmd_Executed(object sender, ExecutedRoutedEventArg
                 };  
                 var formPanel = (StackPanel)(_sp).Children[2];
                 var statusPanel = ((StackPanel)(_sp).Children[3]);
-                await CreateRunContractFormAsync(formPanel, statusPanel, item.Data, transactCheckBox, fromAddressTextBox);
+                await CreateRunContractFormAsync(formPanel, statusPanel, item.Data, transactCheckBox, fromAddressTextBox, () => (estimateGasRadioButton.IsChecked ?? false) ? null : new HexBigInteger((long) customGasNumberBox.Value));
                 dw.ButtonClicked += (cd, args) => { };
                 dw.Closing += (d, args) => { };
                 await dw.ShowAsync();                             
@@ -987,7 +988,7 @@ private void ShowValidationSuccess(StackPanel successPanel, Wpc.TextBlock succes
 
         private void HideValidationSuccess(StackPanel successPanel) => successPanel.Visibility = Visibility.Hidden;
 
-        private async Task CreateRunContractFormAsync(StackPanel form, StackPanel statusPanel, Dictionary<string, object> contractData, CheckBox transactCheckBox, Wpc.TextBox fromAddress)
+        private async Task CreateRunContractFormAsync(StackPanel form, StackPanel statusPanel, Dictionary<string, object> contractData, CheckBox transactCheckBox, Wpc.TextBox fromAddress, Func<HexBigInteger> gas)
         {
             form.Children.Clear();  
             var errors = (Wpc.TextBlock)((Grid)statusPanel.Children[0]).Children[0];
@@ -1027,9 +1028,7 @@ private async Task CreateRunContractFormAsync(StackPanel form, StackPanel status
                 ShowValidationErrors(errors, $"Could not retrieve balance for contract. {balr.FailureMessage}");
                 return;
             }
-
-           
-            
+                       
             foreach (var function in _abi.Functions)
             {
                 var vsp = new StackPanel()
@@ -1078,8 +1077,14 @@ private async Task CreateRunContractFormAsync(StackPanel form, StackPanel status
 
                     button.Click += (s, e) =>
                     {
-                        var paramVals = GetContractFunctionParams(vsp, function.InputParameters.ToDictionary(ip => ip.Name, ip => ip.Type));
-                        if (paramVals.Length != function.InputParameters.Count())
+                        var paramVals = GetContractFunctionParams(vsp, function.InputParameters.ToDictionary(ip => ip.Name, ip => ip.Type), out string paramError);
+                        if (!string.IsNullOrEmpty(paramError))
+                        {
+                            ShowValidationErrors(errors, $"Error parsing function parameters: \n{paramError}");
+                            VSUtil.LogToStratisEVMWindow($"\n========== Call contract {address} at {rpcurl} failed.==========\nError parsing function parameters: {paramError}");
+                            return;
+                        }
+                        else if (paramVals.Length != function.InputParameters.Count())
                         {
                             ShowValidationErrors(errors, $"The {function.Name} function requires {function.InputParameters.Count()} parameters.");
                             VSUtil.LogToStratisEVMWindow($"\n========== Call contract {address} at {rpcurl} failed.==========\nThe {function.Name} function requires {function.InputParameters.Count()} parameters.");
@@ -1098,7 +1103,7 @@ private async Task CreateRunContractFormAsync(StackPanel form, StackPanel status
                                 ShowValidationErrors(errors, "Enter a valid from address to send the transaction from.");
                                 return;
                             }
-                            r = ThreadHelper.JoinableTaskFactory.Run(() => ExecuteAsync(Network.SendContractTransactionAsync(rpcurl, address, abi, function.Name, fromAddress.Text, functionInput: paramVals)));
+                            r = ThreadHelper.JoinableTaskFactory.Run(() => ExecuteAsync(Network.SendContractTransactionAsync(rpcurl, address, abi, function.Name, fromAddress.Text, gas:gas(), functionInput: paramVals)));
                         }
                         else
                         {
@@ -1134,7 +1139,7 @@ private async Task CreateRunContractFormAsync(StackPanel form, StackPanel status
                                 ShowValidationErrors(errors, "Enter a valid from address to send the transaction from.");
                                 return;
                             }
-                            r = ThreadHelper.JoinableTaskFactory.Run(() => ExecuteAsync(Network.SendContractTransactionAsync(rpcurl, address, abi, function.Name, fromAddress.Text)));
+                            r = ThreadHelper.JoinableTaskFactory.Run(() => ExecuteAsync(Network.SendContractTransactionAsync(rpcurl, address, abi, function.Name, fromAddress.Text, gas:gas())));
                         }
                         else
                         {
@@ -1162,8 +1167,9 @@ private async Task CreateRunContractFormAsync(StackPanel form, StackPanel status
             }
         }
 
-        private object[] GetContractFunctionParams(StackPanel form, Dictionary<string, string> paramTypes)
+        private object[] GetContractFunctionParams(StackPanel form, Dictionary<string, string> paramTypes, out string error)
         {
+            error = null;
             Dictionary<string, (string, string)> paramValues = new Dictionary<string, (string, string)>();
             foreach (var child in form.Children)
             {
@@ -1176,7 +1182,15 @@ private object[] GetContractFunctionParams(StackPanel form, Dictionary<string, s
                     }
                 }
             }
-            return Contract.ParseFunctionParameterValues(paramValues);
+            try
+            {                 
+                return Contract.ParseFunctionParameterValues(paramValues);
+            }
+            catch (Exception ex)
+            {
+                error = ex.Message;
+                return Array.Empty<object>();
+            }            
         }
         #endregion