-
Notifications
You must be signed in to change notification settings - Fork 221
Fix: Add missing retrieveFilter parameter to retrieve tool spec #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add missing retrieveFilter parameter to retrieve tool spec #292
Conversation
|
Were you able to test this to ensure that the tool works after this change? |
HI @mehtarac Yes, I tested this. All 21 retrieve tests pass: Filter-specific tests that passed:
The retrieveFilter functionality was already fully implemented in the backend code with tests. This PR simply adds the missing schema definition so agents can discover it. The change is purely additive and doesn't modify any existing logic. |
|
Hi @mehtarac , thanks for the approval! Just following up on this PR to request another review. Please let me know if there's anything needed from my end to get this merged. Thank you! |
Description
The
retrieveFilterparameter was implemented in the retrieve tool's code but was missing from theTOOL_SPECinputSchema. This prevented agents from discovering and using the filter functionality, even though the backend code fully supported it.This PR adds
retrieveFilterto the tool's inputSchema with comprehensive documentation of all supported operators based on AWS Bedrock's RetrievalFilter API.Related Issues
N/A
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.