Dag creation #9
Open
Dag creation #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAR FIle Implemetatioon
tests: add tests for the CreateNewAdder func in the DAGService
Fix: upgraded deprecated packages
|
Pulling @volmedo to review! Thank you! |
volmedo
requested changes
Apr 21, 2025
Comment on lines
+1
to
+5
| <<<<<<< HEAD | ||
| dist/ | ||
| ======= | ||
| go.sum | ||
| >>>>>>> dag_repo/main |
There was a problem hiding this comment.
I guess you forgot to remove the merge conflict marks 🙂
There was a problem hiding this comment.
some more merge conflict marks in this file, please resolve
Comment on lines
+146
to
+147
| adder.mu.Lock() | ||
| defer adder.mu.Unlock() |
There was a problem hiding this comment.
do we need a mutex for this? It looks to me the kind of job that sync.Once would be more suited for.
Comment on lines
+24
to
+32
| const ( | ||
| DefaultChunkSize = "size-1048576" // 1MB chunks | ||
|
|
||
| MaxLinks = 1048576 | ||
|
|
||
| UseRawLeaves = true | ||
|
|
||
| LiveCacheSize = uint64(256 << 10) // 256KB | ||
| ) |
There was a problem hiding this comment.
please remove this file from your PR. It looks like it's overwriting the existing README.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of DAG in Golang for Storacha go-w3up
Adder Package Implementation
The adder package provides functionality to add files and directories to content-addressed storage by chunking data, constructing a Directed Acyclic Graph (DAG), and integrating with a Mutable File System for retrieval. The go-w3s-client provides a reference implementation for building the DAG in this repo.