Merge pull request #214 from tushar2407/basemodelissue

fix: fix to issue #213

Author: StochasticRomanAgeev

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "xturing"
-version = "0.1.4"
+version = "0.1.5"
 description = "Fine-tuning, evaluation and data generation for LLMs"
 
 authors = [

src/xturing/__about__.py

@@ -1 +1 @@
-__version__ = "0.1.4"
+__version__ = "0.1.5"

src/xturing/models/causal.py

@@ -19,6 +19,7 @@
 from xturing.trainers.base import BaseTrainer
 from xturing.trainers.lightning_trainer import LightningTrainer
 from xturing.utils.logging import configure_logger
+from xturing.utils.utils import _filter_args
 
 logger = configure_logger(__name__)
 
@@ -31,13 +32,17 @@ def __init__(
         model_name: Optional[str] = None,
         target_modules: Optional[List[str]] = None,
     ):
-        self.engine = BaseEngine.create(
-            engine,
+        arguments = dict(
             weights_path=weights_path,
             model_name=model_name,
             target_modules=target_modules,
         )
 
+        self.engine = BaseEngine.create(
+            engine,
+            **_filter_args(arguments),
+        )
+
         self.model_name = engine.replace("_engine", "")
 
         # Finetuning config

src/xturing/utils/utils.py

@@ -124,3 +124,13 @@ def extract_text_from_directory(directory_path):
     print(f"Finished processing directory, the text files are stored in {temp_dir}.")
 
     return temp_dir
+
+
+def _filter_args(self, arguments: dict):
+    to_delete = []
+    for key, value in arguments.items():
+        if value is None:
+            to_delete.append(key)
+    for key in to_delete:
+        del arguments[key]
+    return arguments