-
Notifications
You must be signed in to change notification settings - Fork 26
chore(npm): Update release npm action to stop using tokens #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependencies and transitions the npm publishing workflow to use OIDC trusted publishers instead of long-lived tokens, improving security.
- Updated multiple development and production dependencies to their latest versions
- Migrated release workflows from token-based authentication to OIDC trusted publishing
- Enhanced workflow step names with emoji prefixes for better readability
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependency versions including sass-embedded, build tools, testing frameworks, and type definitions; changed quote style in prettier script |
| package-lock.json | Lockfile updates reflecting the new dependency versions from package.json |
| .github/workflows/release.yml | Removed npm token parameters, switched to GITHUB_TOKEN, pinned publish action to specific commit, and added emoji prefixes to job/step names |
| .github/workflows/main.yml | Added emoji prefixes to step names for improved readability |
| .github/workflows/build.yml | Added emoji prefixes to step names for improved readability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: N/A
What is the new behavior?
Updated test tooling:
sass-embeddedto^1.93.2@rollup/plugin-node-resolveto^16.0.3@rollup/plugin-typescriptto^12.3.0@stencil/coreto^4.38.2@types/nodeto^24.9.2jestto^30.2.0prettierto^3.6.2rollupto^4.52.5terserto^5.44.0ts-jestto^29.4.5typescriptto~5.9.3Removed the token input from
release.ymlso the job depends solely on OIDC.Kept the PAT input used for tagging/releases while leaving the composite action to request npm tokens via OIDC.
Confirmed that the publish job retains permissions:
id-token: write, satisfying npm’s trusted publisher guidance.Does this introduce a breaking change?
Testing
Other information
id-token: write,actions/setup-nodewith registry URL, npm ≥ 11.5.1,npm publish --provenance).