test: use Faker (#6919)

* test: use Faker

* chore: snake case

Author: igor-sirotin

tests-functional/clients/services/wakuext.py

@@ -1,8 +1,9 @@
+from enum import Enum
 from typing import TypedDict, Union
+
 from clients.rpc import RpcClient
 from clients.services.service import Service
 from resources.enums import MessageContentType
-from enum import Enum
 
 
 class PushNotificationRegistrationTokenType(Enum):
@@ -205,8 +206,8 @@ def send_group_chat_invitation_rejection(self, invitation_request_id: str):
         response = self.rpc_request("sendGroupChatInvitationRejection", params)
         return response
 
-    def create_community(self, name, color="#ffffff", membership=3):
-        params = [{"membership": membership, "name": name, "color": color, "description": name}]
+    def create_community(self, name, description, color="#ffffff", membership=3):
+        params = [{"membership": membership, "name": name, "color": color, "description": description}]
         response = self.rpc_request("createCommunity", params)
         return response
 

tests-functional/clients/status_backend.py

@@ -1,30 +1,32 @@
 import json
 import logging
-import string
+import os
 import tempfile
 import time
-import random
 import uuid
-import requests
-import os
 
+import requests
 from tenacity import retry, stop_after_delay, wait_fixed
 
 import resources.constants as constants
-from clients.services.wallet import WalletService
-from clients.services.wakuext import WakuextService, PushNotificationRegistrationTokenType
+from clients.api import ApiClient
+from clients.expvar import ExpvarClient
+from clients.metrics import Events, StatusGoMetrics
+from clients.rpc import RpcClient
 from clients.services.accounts import AccountService
-from clients.services.settings import SettingsService
 from clients.services.connector import ConnectorService
+from clients.services.settings import SettingsService
+from clients.services.wakuext import (
+    WakuextService,
+    PushNotificationRegistrationTokenType,
+)
+from clients.services.wallet import WalletService
 from clients.signals import SignalClient, SignalType
-from clients.rpc import RpcClient
-from clients.api import ApiClient
-from clients.metrics import Events, StatusGoMetrics
-from clients.expvar import ExpvarClient
 from clients.statusgo_container import StatusBackendContainer
-from utils.config import Config
 from resources.constants import USE_IPV6, user_1, ANVIL_NETWORK_ID, Account
+from utils import fake
 from utils import keys
+from utils.config import Config
 
 NANOSECONDS_PER_SECOND = 1_000_000_000
 
@@ -234,10 +236,7 @@ def import_data(self, src_path: str, dest_path: str):
             dst.write(src.read())
 
     def _set_display_name(self, **kwargs):
-        self.display_name = kwargs.get(
-            "display_name",
-            f"DISP_NAME_{''.join(random.choices(string.ascii_letters + string.digits + '_-', k=10))}",
-        )
+        self.display_name = kwargs.get("display_name", fake.profile_name())
 
     def _create_account_request(self, user, **kwargs):
         self.password = kwargs.get("password", user.password)

tests-functional/requirements.txt

@@ -12,4 +12,5 @@ pytest-xdist~=3.6.1
 pytest-rerunfailures==13.0
 web3~=7.9.0
 matplotlib>=3.5.0
-eth-typing~=5.2.1
+eth-typing~=5.2.1
+faker~=37.6.0

tests-functional/steps/messenger.py

@@ -1,15 +1,16 @@
 # pyright: reportOptionalMemberAccess=false
 # pyright: reportAttributeAccessIssue=false
 import logging
-import random
-import string
 import time
 from uuid import uuid4
+
 import pytest
 from tenacity import retry, stop_after_delay, wait_fixed
+
 from clients.signals import SignalType
 from resources.enums import MessageContentType
 from steps.network_conditions import NetworkConditionsSteps
+from utils import fake
 
 
 class MessengerSteps(NetworkConditionsSteps):
@@ -146,8 +147,7 @@ def join_private_group(self, admin=None, member=None) -> str:
         return response.get("chats", [])[0].get("id")
 
     def create_community(self, node):
-        name = f"vac_qa_community_{''.join(random.choices(string.ascii_letters, k=10))}"
-        response = node.wakuext_service.create_community(name)
+        response = node.wakuext_service.create_community(fake.community_name(), fake.community_description())
         self.community_id = response.get("communities", [{}])[0].get("id")
         return self.community_id
 

tests-functional/tests/test_password.py

@@ -1,12 +1,12 @@
 import logging
-import random
 import re
-import string
 
 import pytest
+
 from clients.api import ApiResponseError
 from clients.signals import SignalType
 from resources.constants import Account
+from utils import fake
 
 
 @pytest.mark.rpc
@@ -33,7 +33,7 @@ def test_verify_wrong_password(self, password, backend_new_profile):
         assert response is False
 
     def test_change_password(self, backend_new_profile):
-        new_password = "".join(random.choices(string.ascii_letters + string.digits, k=8))
+        new_password = fake.profile_password(8)
         backend = backend_new_profile("user")
 
         # Try a wrong password

tests-functional/utils/fake.py

@@ -0,0 +1,21 @@
+from faker import Faker
+
+# Use a single English locale to minimize provider loading
+_faker = Faker("en")
+
+
+def community_name() -> str:
+    return _faker.company()
+
+
+def community_description() -> str:
+    return _faker.sentence()
+
+
+def profile_name() -> str:
+    return _faker.user_name()
+
+
+def profile_password(length: int = 8) -> str:
+    # Letters + digits; no special characters to keep compatibility
+    return _faker.password(length=length, special_chars=False)