stop using nimOldCaseObjects and make CaseTransition warnings errors (#3853)

Author: tersec

GeneralStateTestsDevnet.md

@@ -139,11 +139,6 @@ OK: 5/5 Fail: 0/5 Skip: 0/5
 + valid_multi_inf.json                                            OK
 ```
 OK: 6/6 Fail: 0/6 Skip: 0/6
-## bls12_precompiles_before_fork
-```diff
-+ precompile_before_fork.json                                     OK
-```
-OK: 1/1 Fail: 0/1 Skip: 0/1
 ## bls12_variable_length_input_contracts
 ```diff
 + invalid_gas_g1msm.json                                          OK
@@ -471,10 +466,9 @@ OK: 50/50 Fail: 0/50 Skip: 0/50
 + pointer_to_precompile.json                                      OK
 + pointer_to_static.json                                          OK
 + pointer_to_static_reentry.json                                  OK
-+ set_code_type_tx_pre_fork.json                                  OK
 + static_to_pointer.json                                          OK
 ```
-OK: 16/16 Fail: 0/16 Skip: 0/16
+OK: 15/15 Fail: 0/15 Skip: 0/15
 ## shift_combinations
 ```diff
 + combinations.json                                               OK
@@ -562,4 +556,4 @@ OK: 2/2 Fail: 0/2 Skip: 0/2
 OK: 1/1 Fail: 0/1 Skip: 0/1
 
 ---TOTAL---
-OK: 268/268 Fail: 0/268 Skip: 0/268
+OK: 266/266 Fail: 0/266 Skip: 0/266

config.nims

@@ -83,20 +83,13 @@ if defined(windows):
 #
 if defined(disableMarchNative):
   if defined(i386) or defined(amd64):
-    if defined(macosx):
-      # https://support.apple.com/en-us/105113
-      # "macOS Sonoma is compatible with these computers" lists current oldest
-      # supported x86 models, all of which have Kaby Lake or newer CPUs.
-      switch("passC", "-march=skylake -mtune=generic")
-      switch("passL", "-march=skylake -mtune=generic")
+    if defined(marchOptimized):
+      # https://github.com/status-im/nimbus-eth2/blob/stable/docs/cpu_features.md#bmi2--adx
+      switch("passC", "-march=broadwell -mtune=generic")
+      switch("passL", "-march=broadwell -mtune=generic")
     else:
-      if defined(marchOptimized):
-        # https://github.com/status-im/nimbus-eth2/blob/stable/docs/cpu_features.md#bmi2--adx
-        switch("passC", "-march=broadwell -mtune=generic")
-        switch("passL", "-march=broadwell -mtune=generic")
-      else:
-        switch("passC", "-mssse3")
-        switch("passL", "-mssse3")
+      switch("passC", "-mssse3")
+      switch("passL", "-mssse3")
 elif defined(macosx) and defined(arm64):
   # Apple's Clang can't handle "-march=native" on M1: https://github.com/status-im/nimbus-eth2/issues/2758
   switch("passC", "-mcpu=apple-m1")
@@ -169,16 +162,12 @@ if canEnableDebuggingSymbols:
   # add debugging symbols and original files and line numbers
   --debugger:native
 
---define:nimOldCaseObjects # https://github.com/status-im/nim-confutils/issues/9
-
 switch("warningAsError", "BareExcept:on")
+switch("warningAsError", "CaseTransition:on")
 switch("warningAsError", "UnusedImport:on")
 switch("hintAsError", "ConvFromXtoItselfNotNeeded:on")
 switch("hintAsError", "DuplicateModuleImport:on")
 
-# `switch("warning[CaseTransition]", "off")` fails with "Error: invalid command line option: '--warning[CaseTransition]'"
-switch("warning", "CaseTransition:off")
-
 # nim-kzg shipping their own blst, nimbus-eth1 too.
 # disable nim-kzg's blst
 switch("define", "kzgExternalBlst")

tests/test_coredb/coredb_test_xx.nim

@@ -8,6 +8,8 @@
 # at your option. This file may not be copied, modified, or
 # distributed except according to those terms.
 
+{.push raises: [], gcsafe.}
+
 import
   eth/common,
   ../../execution_chain/db/core_db,
@@ -36,36 +38,48 @@ func cloneWith(
     dbType = CoreDbType(0);
     dbName = "";
       ): CaptureSpecs =
-  result = dsc
-  if network != 0.u256:
-    result.builtIn = true
-    result.network = network
-  elif 0 < genesis.len:
-    result.builtIn = false
-    result.genesis = genesis
+  var res =
+    if network != 0.u256:
+      CaptureSpecs(
+        name: dsc.name,
+        builtIn: true,
+        network: network,
+        files: dsc.files,
+        numBlocks: dsc.numBlocks,
+        dbType: dsc.dbType,
+        dbName: dsc.dbName)
+    elif 0 < genesis.len:
+      CaptureSpecs(
+        name: dsc.name,
+        builtIn: false,
+        genesis: genesis,
+        files: dsc.files,
+        numBlocks: dsc.numBlocks,
+        dbType: dsc.dbType,
+        dbName: dsc.dbName)
+    else:
+      dsc
   if 0 < name.len:
     if name[0] == '-':
-      result.name &= name
+      res.name &= name
     elif name[0] == '+' and 1 < name.len:
-      result.name &= name[1 .. ^1]
+      res.name &= name[1 .. ^1]
     else:
-      result.name = name
+      res.name = name
   if 0 < files.len:
-    result.files = files
+    res.files = files
   if 0 < numBlocks:
-    result.numBlocks = numBlocks
+    res.numBlocks = numBlocks
   if dbType != CoreDbType(0):
-    result.dbType = dbType
+    res.dbType = dbType
   if dbName == "":
-    result.dbName = result.name
+    res.dbName = res.name
   else:
-    result.dbName = dbName
+    res.dbName = dbName
+  res
 
 
-# Must not use `const` here, see `//github.com/nim-lang/Nim/issues/23295`
-# Waiting for fix `//github.com/nim-lang/Nim/pull/23297` (or similar) to
-# appear on local `Nim` compiler version.
-let
+const
   mainSample = CaptureSpecs(
     builtIn: true,
     name:    "main",
@@ -78,7 +92,7 @@ let
     builtIn: true,
     name:    "main",
     network: MainNet,
-    # The extren repo is identified by a tag file
+    # The extern repo is identified by a tag file
     files:   @["mainnet-extern.era1"])        # on external repo
 
   # ------------------