fix: normalize timestamps for eval comparison (#109)

* fix: normalize timestamps for eval comparison

* fix: on operator

---------

Co-authored-by: tore-statsig <tore@statsig>

Author: tore-statsig

src/EvaluationUtils.php

@@ -263,4 +263,20 @@ public static function arrayContainsAll($value, $target): bool
         }
         return true;
     }
+
+    public static function getEpochMs($d): ?int
+    {
+        if ($d === null) {
+            return null;
+        }
+
+        $epoch = (int)$d;
+
+        // If it's in seconds, scale up to ms
+        if ($epoch < 10000000000) { // < 1e10 = definitely seconds
+            $epoch *= 1000;
+        }
+
+        return $epoch;
+    }
 }

src/Evaluator.php

@@ -351,12 +351,18 @@ function evalCondition($user_obj, $condition): ConfigEvaluation
             case 'neq':
                 return new ConfigEvaluation($value !== $target);
             case 'before':
-                return new ConfigEvaluation($value < $target);
+                $first = Utils::getEpochMs($value);
+                $second = Utils::getEpochMs($target);
+                return new ConfigEvaluation($first !== null && $second !== null && $first < $second);
             case 'after':
-                return new ConfigEvaluation($value > $target);
+                $first = Utils::getEpochMs($value);
+                $second = Utils::getEpochMs($target);
+                return new ConfigEvaluation($first !== null && $second !== null && $first > $second);
             case 'on':
-                $a = date('Y-m-d', $value);
-                $b = date('Y-m-d', $target);
+                $first = Utils::getEpochMs($value);
+                $second = Utils::getEpochMs($target);
+                $a = date('Y-m-d', $first);
+                $b = date('Y-m-d', $second);
                 return new ConfigEvaluation($a == $b);
             case 'array_contains_any':
                 if (!is_array($value)) {