8.18.3 has completely broken table card

[pacemaker82]

Hi @springfall2008

I am not sure what HTML change you made in 8.18.3 but it has completely broken the table card I made.

This fix seems to have been the culprit

Now my card has all the columns out of whack - I can't really figure out why yet.

You also seem to have removed the header information from the top of the HTML plan, so no last updated or other info. But separate less urgent issue...

Can you revert this change or describe exactly what you changed so I can look into it?

[pacemaker82]

OK I figured it out

colspan = 2 on the state header cell was unexpected, and not what used to be there. All my data collection assumed it didn't have that, so threw out my calculations (I used indexes and number of columns was now different in the table header).

Second change I dont see here in latest version, but did affect my code was the table headers are now <th> and used to be <td> previously. Maybe that happened in the last few updates you made and only manifested when I needed to see car column data.

[gcoan]

Second change I dont see here in latest version, but did affect my code was the table headers are now and used to be previously

this was a change in 8.18.3

I tend to look at the release details so I can see what has actually changed

Whack-a-mole again

[pacemaker82]

8.18.3 only references the colspan change 464897b

I guess the th change was 8.18.x and I just didn't pick it up until now. That didn't break the columns like we have today, that was definitely caused by the colspan change. Anyway I have rushed out a fix and will figure out backwards compatibility tomorrow

[gcoan]

8.18.3 only references the colspan change 464897b

I guess the th change was 8.18.x

the th change was 8.18.3, can see it in the release details if you look at what files are changed (not just the release description):

[ProximusAl]

I am seeing the same. Every row has a Planned Export column even though I'm set to control charge only..

[gcoan]

I am seeing the same. Every row has a Planned Export column even though I'm set to control charge only..

@ProximusAl have you upgraded to the latest table card https://github.com/pacemaker82/PredBat-Table-Card/releases/tag/v1.5.7.12

this cures the extra exports for me

[ProximusAl]

I am seeing the same. Every row has a Planned Export column even though I'm set to control charge only..

@ProximusAl have you upgraded to the latest table card https://github.com/pacemaker82/PredBat-Table-Card/releases/tag/v1.5.7.12

this cures the extra exports for me

That indeed cured my issue....now I wonder why HACS didnt inform me an update was available?
I was many versions out.

Thank you for letting me know...

[springfall2008]

Sorry about that, I do wonder if it would be better to create a JSON output for use with the plan card otherwise it will keep breaking every time the HTML is updated?

[pacemaker82]

@springfall2008 something was worked on related to that #1288 - I am not sure if its ready for primetime yet though but I agree - JSON would be 100x safer.

[pacemaker82]

8.18.3 only references the colspan change 464897b
I guess the th change was 8.18.x

the th change was 8.18.3, can see it in the release details if you look at what files are changed (not just the release description):

Ah yes - it was under "style" changes https://github.com/springfall2008/batpred/pull/2252/files

[pacemaker82]

To close this one out, I added a new release today that supports both the old and new way of displaying the original plan HTML

https://github.com/pacemaker82/PredBat-Table-Card/releases/tag/v1.5.7.14

[gcoan]

I wonder why HACS didnt inform me an update was available?

HACS only polls for changes once every day or so, so you have to manually tell it to redownload

[gcoan]

Sorry about that, I do wonder if it would be better to create a JSON output for use with the plan card otherwise it will keep breaking every time the HTML is updated?

can we look at this @springfall2008 eitehr #1288 or your own json structure. It was suggested ages ago as being the way forward and would stop the wack-a-mole with the table card and predbat

[springfall2008]

Heads up I made a new release with a total row at the bottom, hopefully that won't break anything