Skip to content

Redis session attributes not thread safe #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imazzeii opened this issue Apr 19, 2025 · 0 comments
Open

Redis session attributes not thread safe #3385

imazzeii opened this issue Apr 19, 2025 · 0 comments
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug

Comments

@imazzeii
Copy link

the following methods

org.springframework.session.data.redis.ReactiveRedisSessionRepository.createSession()
org.springframework.session.data.redis.RedisSessionMapper.apply(String sessionId, Map<String, Object> map)

create a new "org.springframework.session.MapSession" backed by ReactiveRedisSessionRepository.RedisSession, so getAttributes() return an hashmap; it should be a concurrent hashmap since reactor methods could be executed in different threads

also "ReactiveRedisSessionRepository.RedisSession.delta" should be thread safe

@imazzeii imazzeii added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant