Skip to content

SortArray does not support sorting simple array types (integer/string) #4929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nathanukey opened this issue Mar 18, 2025 · 3 comments
Closed

SortArray does not support sorting simple array types (integer/string) #4929

nathanukey opened this issue Mar 18, 2025 · 3 comments
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Milestone
4.5 RC1 (2025.0.0)

Comments

@nathanukey
Copy link
Contributor

nathanukey commented Mar 18, 2025 •
edited
Loading

Referring to https://www.mongodb.com/docs/manual/reference/operator/aggregation/sortArray/

sorting of simple e.g. int array should be possible:

"$sortArray":
{
    "input": [ 1, 4, 1, 6, 12, 5 ],
    "sortBy": 1
}

however ArrayOperators.SortArray.by only accepts type Sort, which seems to always require a property. Not clear if any way to set a simple ASC/DESC order to sort by.

Seems simple feature that has been missed off, or if possible missed of documentation on how to achieve?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 18, 2025
@mp911de mp911de added status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 24, 2025
@mp911de
Copy link
Member

mp911de commented Mar 24, 2025

Thanks for reaching out. Care to submit a pull request?

@nathanukey
Copy link
Contributor Author

Tried to create PR as requested: 5258a80

@ghost
Copy link

ghost commented Apr 10, 2025

Hello team,

I’ve addressed the issue with sorting simple arrays (integers/strings) in PR #4943 . The fix includes the addition of the byValueAscending() and byValueDescending() methods, along with updated tests to ensure correct functionality.

Please don’t hesitate to reach out if any further modifications or adjustments are needed. I’m happy to make any necessary changes.

Best regards,
Ranzy Blessings

@ghost ghost mentioned this issue Apr 10, 2025
Closed
christophstrobl pushed a commit that referenced this issue Apr 21, 2025
@christophstrobl
Add support for sorting simple arrays (integers/strings) with SortArr…
36a9c22 
…ay ()

- Added methods `byValueAscending()` and `byValueDescending()` to the SortArray class
  to support sorting simple array types (e.g., integers, strings) in ascending and descending order.
- Updated tests to verify the correct functionality of sorting arrays by value.
- Refactored SortArray to handle sorting of simple types without requiring a property for sorting.

For more details, refer to: https://www.mongodb.com/docs/manual/reference/operator/aggregation/sortArray/

Resolves: #4929
Original Pull Request: #4943

Signed-off-by: Ranzy Blessings <[email protected]>
christophstrobl pushed a commit that referenced this issue Apr 21, 2025
@nathanukey @christophstrobl
Add support for sorting simple arrays by direction.
1ffa287 
Add method to provide sorting direction to sort array aggregation.

Related to: #4929
Original Pull Request: #4935

Signed-off-by: Nathan McDonald <[email protected]>
christophstrobl pushed a commit that referenced this issue Apr 21, 2025
@nathanukey @christophstrobl
Add support for sorting simple arrays by direction.
37061db 
Add method to provide sorting direction to sort array aggregation.

Related to: #4929
Original Pull Request: #4935

Signed-off-by: Nathan McDonald <[email protected]>
@christophstrobl christophstrobl added this to the 4.5 RC1 (2025.0.0) milestone Apr 21, 2025
christophstrobl pushed a commit that referenced this issue Apr 22, 2025
@christophstrobl
Add support for sorting simple arrays (integers/strings) with SortArr…
98f871b 
…ay ()

- Added methods `byValueAscending()` and `byValueDescending()` to the SortArray class
  to support sorting simple array types (e.g., integers, strings) in ascending and descending order.
- Updated tests to verify the correct functionality of sorting arrays by value.
- Refactored SortArray to handle sorting of simple types without requiring a property for sorting.

For more details, refer to: https://www.mongodb.com/docs/manual/reference/operator/aggregation/sortArray/

Resolves: #4929
Original Pull Request: #4943

Signed-off-by: Ranzy Blessings <[email protected]>
christophstrobl pushed a commit that referenced this issue Apr 22, 2025
@nathanukey @christophstrobl
Add support for sorting simple arrays by direction.
5db56b2 
Add method to provide sorting direction to sort array aggregation.

Related to: #4929
Original Pull Request: #4935

Signed-off-by: Nathan McDonald <[email protected]>
christophstrobl pushed a commit that referenced this issue Apr 22, 2025
@christophstrobl
Add support for sorting simple arrays (integers/strings) with SortArr…
a9f48ae 
…ay ()

- Added methods `byValueAscending()` and `byValueDescending()` to the SortArray class
  to support sorting simple array types (e.g., integers, strings) in ascending and descending order.
- Updated tests to verify the correct functionality of sorting arrays by value.
- Refactored SortArray to handle sorting of simple types without requiring a property for sorting.

For more details, refer to: https://www.mongodb.com/docs/manual/reference/operator/aggregation/sortArray/

Resolves: #4929
Original Pull Request: #4943

Signed-off-by: Ranzy Blessings <[email protected]>
christophstrobl pushed a commit that referenced this issue Apr 22, 2025
@nathanukey @christophstrobl
Add support for sorting simple arrays by direction.
d9a098f 
Add method to provide sorting direction to sort array aggregation.

Related to: #4929
Original Pull Request: #4935

Signed-off-by: Nathan McDonald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Projects
None yet
Milestone
4.5 RC1 (2025.0.0)
Development

No branches or pull requests
4 participants
@mp911de @christophstrobl @spring-projects-issues @nathanukey