Avoid matching multipart parameters annotated with @ModelAttribute #3277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments. Fixes spring-projects#3258 Related tickets spring-projects#2937 Signed-off-by: Chris Bono <[email protected]>
onobc
commented
Apr 24, 2025
| if (parameter.getParameterAnnotation(ProjectedPayload.class) != null | ||
| || parameter.getParameterAnnotation(ModelAttribute.class) != null) { | ||
| // Annotated parameter (excluding multipart @ModelAttribute) | ||
| if (parameter.hasParameterAnnotation(ProjectedPayload.class) || |
There was a problem hiding this comment.
It seems that the proxy handler does not properly handle multipart arguments, but the request param method handler does properly support multipart params. Is this the proper fix or should the proxy handler also support multipart args properly? cc: @odrotbohm @mp911de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments.
In 3.3.3 the
ProxyingHandlerMethodArgumentResolverwould report that it does not support the@ModelAttribute MultipartFile fileparameter and then the next handler in the chain (RequestParamMethodArgumentResolver) was able to properly handle the multipart file arg.In 3.3.4 (commit) the
ProxyingHandlerMethodArgumentResolverreports that it does support the@ModelAttribute MultipartFile fileparameter and then it fails to properly handle the multipart file arg.Fixes #3258
Related tickets #2937