Skip to content

Spring Data Commons 3.3.4 breaks @ModelAttribute handling #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sdeleuze opened this issue Mar 20, 2025 · 0 comments · May be fixed by #3277
Open

Spring Data Commons 3.3.4 breaks @ModelAttribute handling #3258

sdeleuze opened this issue Mar 20, 2025 · 0 comments · May be fixed by #3277
Assignees
@mp911de @onobc
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@sdeleuze
Copy link
Contributor

As explored in #33791 and visible with a slightly modified version of the reproducer https://github.com/EnyaEnya/multipart-null, adding org.springframework.boot:spring-boot-starter-data-jpa to the project breaks @ModelAttribute handling as of Spring Boot 3.3.4, and I have been able to reproduce only by adding org.springframework.data:spring-data-commons:3.3.4 to the project.

The same project with org.springframework.data:spring-data-commons:3.3.3 or without Spring Data is fine.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 20, 2025
@sdeleuze sdeleuze mentioned this issue Mar 20, 2025
Closed
@mp911de mp911de self-assigned this Mar 20, 2025
onobc added a commit to onobc/spring-data-commons that referenced this issue Apr 24, 2025
@onobc
Avoid matching multipart parameters annotated with @ModelAttribute
50ed578 
The ProxyHandlerMethodArgumentResolver now avoids matching multipart parameters annotated with @ModelAttribute. This allows multipart parameters to be handled by RequestParamMethodArgumentResolver which properly handles multipart arguments.

Fixes spring-projects#3258
Related tickets spring-projects#2937

Signed-off-by: Chris Bono <[email protected]>
@onobc onobc linked a pull request Apr 24, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mp911de mp911de

@onobc onobc

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid matching multipart parameters annotated with @ModelAttribute onobc/spring-data-commons
4 participants
@sdeleuze @mp911de @spring-projects-issues @onobc