How to preserve date created, date modified date accessed of folders?

[anmac1789]

How do I preserve using this method of folder date created, date modified, date accessed of android phone when it is connected to my PC? I want to copy folders inside android to PC preserving all these dates exactly

[IzzySoft]

Just noticed this now – seems to be the same issue I have in #59 just the other way around (you ask about "from device" aka adb pull, I about "to device" aka adb push).

[anmac1789]

Just noticed this now – seems to be the same issue I have in #59 just the other way around (you ask about "from device" aka adb pull, I about "to device" aka adb push).

Omg last time i posted was april last year !!!! it took so long for a reply i gave up. Is it even possible anymore ?

[IzzySoft]

Is it even possible anymore ?

I cannot tell (I maybe can read a little C++ but certainly not write). @spion is still active (though maybe on different projects), so I hope the details on my issue plus the fact yours existing as well and even for a year now, most likely being fixed by whatever fixes the other one (thus killing 2 issues with 1 patch) might trigger him to give this project some love again.

[anmac1789]

Is it even possible anymore ?

I cannot tell (I maybe can read a little C++ but certainly not write). @spion is still active (though maybe on different projects), so I hope the details on my issue plus the fact yours existing as well and even for a year now, most likely being fixed by whatever fixes the other one (thus killing 2 issues with 1 patch) might trigger him to give this project some love again.

is he even developing the software ??

[spion]

I've been thinking about switching this project to Rust, as I'm not very good at writing safe C++ code (in fact, I'm quite slow at writing C++ in general, which has made it very difficult to find the time to work on it).

One idea to help this move further is to try ./adbfs -f - that should show all the commands that adbfs runs. With that log we could try and identify what the differences are between adbfs and a normal push/pull more easily, which should make it easier to patch them up.

[anmac1789]

I've been thinking about switching this project to Rust, as I'm not very good at writing safe C++ code (in fact, I'm quite slow at writing C++ in general, which has made it very difficult to find the time to work on it).

One idea to help this move further is to try ./adbfs -f - that should show all the commands that adbfs runs. With that log we could try and identify what the differences are between adbfs and a normal push/pull more easily, which should make it easier to patch them up.

What is rust ? is this related somehow to adbfs ?

[spion]

Another note: it seems like fuse has moved on - we now have fuse3, which is what most distros use. I tried porting over some of the changes that maz-1 did to get it to work on fuse3 (https://github.com/maz-1/adbfs-rootless) but AFAICT the timestamps appear to be completely lost.

[spion]

Rust is a programming language (i.e. I'd like to rewrite this project in Rust)

Its somewhat of an upfront cost but after that development should be much more of a breeze.

[IzzySoft]

Ah, and there's a difference indeed:

--*-- exec_command: adb push '/tmp/adbfs-aw7waR/-storage-emulated-0-Podcasts-cinnamon-restart' '/storage/emulated/0/Podcasts/cinnamon-restart'

adbfs gives the target name explicitly. But not only that, it does a bunch more things I have no idea why.

Log

--*-- exec_command: adb push '/tmp/adbfs-aw7waR/-storage-emulated-0-Podcasts-cinnamon-restart' '/storage/emulated/0/Podcasts/cinnamon-restart'
invalidate cache /storage/emulated/0/Podcasts/cinnamon-restart
--*-- exec_command: adb shell "sync"
invalidate cache /storage/emulated/0/Podcasts/cinnamon-restart
adb_getattr
--*-- exec_command: adb shell "ls -l -a -d '/storage/emulated/0/Podcasts/cinnamon-restart'" 2>&1
-- adb_open --/storage/emulated/0/Podcasts/cinnamon-restart /tmp/adbfs-aw7waR/-storage-emulated-0-Podcasts-cinnamon-restart
ls -l -a -d '/storage/emulated/0/Podcasts/cinnamon-restart'
--*-- exec_command: adb shell "ls -l -a -d '/storage/emulated/0/Podcasts/cinnamon-restart'"
--*-- exec_command: adb pull '/storage/emulated/0/Podcasts/cinnamon-restart' '/tmp/adbfs-aw7waR/-storage-emulated-0-Podcasts-cinnamon-restart'
flag is: 0
invalidate cache /storage/emulated/0/Podcasts/cinnamon-restart
--*-- exec_command: adb push '/tmp/adbfs-aw7waR/-storage-emulated-0-Podcasts-cinnamon-restart' '/storage/emulated/0/Podcasts/cinnamon-restart'
invalidate cache /storage/emulated/0/Podcasts/cinnamon-restart
--*-- exec_command: adb shell "sync"

Looks like it pushes it multiple times, and in between also pulls it (I actually copied it twice as the first time I had no output, using the same session in a Midnight Commander window – but I definitely did not pull it, I just removed it in between).

And finally, the last command is resolving the riddle:

touch '/storage/emulated/0/Podcasts/cinnamon-restart'

WHY? It's not the way adbfs pushes the file – it explicitly sets the time stamp to "now" with an explicit final touch 😱

The only mention of touch I find in static int adb_utimens(const char *path, const struct timespec ts[2]) – but I don't see where that is called; due to adbfs_oper.utimens = adb_utimens; my guess is that's called by FUSE. Doesn't FUSE pass the timespec along? And not fully related, why is that timestamp increased by 50 (according to the code) – or rather not passed at all (according to the debug output)? For reference:

static int adb_utimens(const char *path, const struct timespec ts[2]) {
    string path_string;
    path_string.assign(path);
    fileData[path_string].timestamp = fileData[path_string].timestamp + 50;
   
    shell_escape_path(path_string);
   
    queue<string> output;
    string command = "touch '";
    command.append(path_string);
    command.append("'");
    cout << command<<"\n";
    adb_shell(command);

    // If we forgot to mount -o rescan then we can remount and touch to trigger the scan.
    if (adbfs_conf.rescan) adb_rescan_file(path_string);

    return 0;
}

Where is it passed? It's calculated by fileData[path_string].timestamp = fileData[path_string].timestamp + 50; – but where is that fileData used in the executed command? Further, the variable passed is called timespec (or ts? I'm a bit confused there) – I don't see that referenced and being used inside.

[IzzySoft]

PS: While I understand a rewrite in Rust, that's not installed on my machine with the default build tools. Checked with my package manager, no idea what packages I'd need for that – but it would be quite an extra for non-devs. Would you then provide binaries?

As for "timestamps lost" – maybe there could be an option turning adb_utimens into a stub, so the final touch is never executed? So if one just wants to run a sync (like me), one could simply mount with that option (e.g. adbfs -t droid) for that task. adb push deals fine with timestamps to my experience, so no touch would be needed for that.

[anmac1789]

Okay so in comparison from what I understand, in NTFS windows, if you have a parent older with subfolders,changing anything inside the subfolders changes the date modified and date accessed but leaves the parent folder timestamps alone. If somehow, this could be tweaked with android to replicate the same behaviour for subfolders then we have a soution where the date and time won't change if you make changes within a subfodler. Mind you a few notes-- this COULD only works for parent folders not subfolders. Any considerations of my idea?

[spion]

I pushed an update to feat/merge-libfuse-3 as it looks like @maz-1 has done an incredible job at fixing some of these issues by passing the times to the touch command by default. I think I also managed to save the timestamps by relaxing the restrictions for their parsing a little.

https://github.com/spion/adbfs-rootless/tree/feat/merge-libfuse-3 is the new code - note that there is a slight change in the readme too, as this has been upgraded for fuse3 rather than fuse.

[anmac1789]

I pushed an update to feat/merge-libfuse-3 as it looks like @maz-1 has done an incredible job at fixing some of these issues by passing the times to the touch command by default. I think I also managed to save the timestamps by relaxing the restrictions for their parsing a little.

https://github.com/spion/adbfs-rootless/tree/feat/merge-libfuse-3 is the new code - note that there is a slight change in the readme too, as this has been upgraded for fuse3 rather than fuse.

so all timestamps are preserved ?

[spion]

Gave it my best shot to test the end result, to the extent of my knowledge it looks OK. But please give it a try yourself. I could have missed something. (try the branch)

[anmac1789]

Gave it my best shot to test the end result, to the extent of my knowledge it looks OK. But please give it a try yourself. I could have missed something. (try the branch)

Would it be okay if you could provide a screenshot as a test ?