Batch Edit columns are presented in a different order than the query

[grantfitzsimmons]

Describe the bug
When users build a query, there is a large degree of intentionality in how it is ordered.
Like items are grouped together, which often communicates what data is necessary to see in what order to make reasonable decisions about batch edits that are going to be made.

If this order is not maintained, it be complex and difficult to make data moves.

Label Query.json (in this example, on the KU Herpetology database)

When the query is run, the results match the ordering in the query lines:

Columns are in this order:

Catalog #,Family - Full Name,Genus - Full Name,Species - Full Name,Subspecies - Full Name,Determinations - Current,Type Status,Island Group,Country - Full Name,State - Full Name,County - Full Name,Locality,Locality Details - Island

The user is often prompted to add a bunch of tree ranks:

So be it, there is no other choice at this time. The next step:

Then the columns are in this order:

Catalog #,Locality,Default Geography Definition - Country - Geography name,Default Geography Definition - County - Geography name,Default Geography Definition - State - Geography name,Island Group,Locality Details - Island,Determinations - Current,Type Status,Herps taxonomy tree - Family - Taxon name,Herps taxonomy tree - Genus - Taxon name,Herps taxonomy tree - Species - Taxon name,Herps taxonomy tree - Subfamily - Taxon name,Herps taxonomy tree - Subgenus - Taxon name,Herps taxonomy tree - Subspecies - Taxon name,Herps taxonomy tree - Subtribe - Taxon name,Herps taxonomy tree - Tribe - Taxon name

Side-by-side comparison

Column name	Pos in Query Builder	Pos in Batch Edit	Notes
Catalog #	1	1	identical
Family	2	11	renamed in Batch Edit to “Herps taxonomy tree - Family - Taxon name”
Genus	3	12	renamed in Batch Edit to “Herps taxonomy tree - Genus - Taxon name”
Species	4	13	renamed in Batch Edit to “Herps taxonomy tree - Species - Taxon name”
Subspecies	5	16	renamed in Batch Edit to “Herps taxonomy tree - Subspecies - Taxon name”
Determinations - Current	6	8	identical
Type Status	7	9	identical
Island Group	8	6	same name, different position
Country	9	3	renamed in Batch Edit to “Default Geography Definition - Country - Geography name”
State	10	5	renamed in Batch Edit to “Default Geography Definition - State - Geography name”
County	11	4	renamed in Batch Edit to “Default Geography Definition - County - Geography name”
Locality	12	2	identical
Locality Details - Island	13	7	identical

Columns only in Batch Edit (not in Query Builder):

Column name	Pos in Batch Edit
Herps taxonomy tree - Subfamily - Taxon name	14
Herps taxonomy tree - Subgenus - Taxon name	15
Herps taxonomy tree - Subtribe - Taxon name	17
Herps taxonomy tree - Tribe - Taxon name	18

Summary:

• All original columns are present in Batch Edit, but many have been prefixed (e.g. “Herps taxonomy tree – …”) or re-ordered.
• Batch Edit introduces four extra taxonomy-level columns under the “Herps taxonomy tree” hierarchy.
• The “Country/State/County – Full Name” trio has been replaced with “Default Geography Definition – … – Geography name.”

To Reproduce
Steps to reproduce the behavior:

1. Build a query
2. Save it
3. Run the query
4. Click "Batch Edit"
5. See that the order is not respected

When reporting an issue on the production branch or any development version of Specify, please try to recreate the issue on the latest tagged release (v7) and indicate if it does not occur there, indicating a regression.

Expected behavior
The columns in Batch Edit should be in the same order as the columns in the query results.

Crash Report

If the bug resulted in an error message, please click on "Download Error Message" and attach it here. If there is no error, please follow these instructions to download your System Information.

Please fill out the following information manually:

• OS: macOS
• Browser: Arc
• Specify 7 Version: v711-prerelease (13e7135)
• Database Name: KUHerps_PreservationChain, local database
• Collection name: Herpetology
• User Name: spherpsadmin

[CarolineDenis]

NOTES:

• This occurs when there is tree table.
• If there is no tree rank the order will be what was set in the query
• The tree ranks gets added in alphabetical order atm
• If the rank comes from another tree than it's added at the end
• Same issue as / duplicate of: Missing taxon ranks are added in the incorrect order in batch edit #6452
• Maybe we should consider ordering by rank id and not alphabetical by tree?
• Need the renaming of ranks since multiple trees because the same rank can appear across multiple trees

[grantfitzsimmons]

Same issue as / duplicate of: #6452

To clarify the difference, this changes the order of all fields, regardless of whether or not the fields are from a tree table

Maybe we should consider ordering by rank id and not alphabetical by tree?

This would be much more logical

Need the renaming of ranks since multiple trees because the same rank can appear across multiple trees

Not sure we need to show Default Geography Definition - County - Geography name when we could just show County (and in all cases where there can only be one tree)

Even in cases where you have Herps taxonomy tree - Subfamily - Taxon name, this could really just be Herps taxonomy tree - Subfamily

[realVinayak]

Even in cases where you have Herps taxonomy tree - Subfamily - Taxon name, this could really just be Herps taxonomy tree - Subfamily

Could be. But, backend doesn't localize any field add to ranks -- it is complicated. See this comment: #6196 (comment)

Specifically, under Bad things
2. Doesn't do any localizing -- needs hacks.

Not sure we need to show Default Geography Definition - County - Geography name when we could just show County (and in all cases where there can only be one tree)

This is in similar vein, I gave up on localization since it requires hacks.

[realVinayak]

To clarify the difference, this changes the order of all fields, regardless of whether or not the fields are from a tree table

This is interesting. The order between non-tree fields should be same (and all tree ranks should appear at the end).

[bronwyncombs]

Jack @ CUIC has reported an issue with this as well:

Query mapping and results:

Batch Edit columns:

Batch Edit Data Mapper: