Skip to content

Version number should be required for all version fields #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
grantfitzsimmons opened this issue Feb 3, 2023 · 1 comment · May be fixed by #6384
Open

Version number should be required for all version fields #2937

grantfitzsimmons opened this issue Feb 3, 2023 · 1 comment · May be fixed by #6384
Assignees
@CarolineDenis
Labels
1 - Bug Incorrect behavior of the product 2 - Database/Schema Issues that are related to the underlying database and schema
Milestone
7.12.0

Comments

@grantfitzsimmons
Copy link
Member

grantfitzsimmons commented Feb 3, 2023 •
edited
Loading

Specify 7 Crash Report - 2023-02-02T13_45_04.375Z.txt

If there is not a value, it causes a crash due to the SpAuditLog.

_mysql_exceptions.OperationalError: (1048, "Column 'RecordVersion' cannot be null")

image

Specify 7 Crash Report - 2023-02-03T18 14 18.894Z.txt

If a record's version field is null, and it can be, it will throw a 500 error when it tries to get recorded

Reported By: Gothenburg museum of natural history
@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product pri:unknown labels Feb 3, 2023
@grantfitzsimmons grantfitzsimmons moved this to 📋 Backlog in Back-End Backlog Mar 9, 2023
@grantfitzsimmons grantfitzsimmons added 2 - Database/Schema Issues that are related to the underlying database and schema and removed Unsorted labels Jul 3, 2023
@emenslin emenslin added the todo:verify Needs Verification label Jul 25, 2024
@CarolineDenis
Copy link
Contributor

NOTES:
need to make a Django migration in the ‘patches’ app that sets all NULL version fields to 0 and then one that makes it a database requirement

@CarolineDenis CarolineDenis self-assigned this Apr 2, 2025
@CarolineDenis CarolineDenis removed the todo:verify Needs Verification label Apr 2, 2025
CarolineDenis added a commit that referenced this issue Apr 2, 2025
@CarolineDenis
Update version=null to version=0 and make version required
e322b34 
Fixes #2937
@CarolineDenis CarolineDenis added this to the 7.10.3 milestone Apr 2, 2025
@CarolineDenis CarolineDenis linked a pull request Apr 2, 2025 that will close this issue
Open
2 tasks
@CarolineDenis CarolineDenis modified the milestones: 7.10.3, 7.11.0 Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarolineDenis CarolineDenis

Labels
1 - Bug Incorrect behavior of the product 2 - Database/Schema Issues that are related to the underlying database and schema
Projects
Back-End Backlog
Status: 📋 Backlog
Schema Changes
Status: No status
Milestone
7.12.0
Development

Successfully merging a pull request may close this issue.

Update version=null to version=0 and make version required specify/specify7
3 participants
@grantfitzsimmons @CarolineDenis @emenslin