Skip to content

Already Saved Query with enabled Save Query Button #3548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carlosmbe opened this issue May 31, 2023 · 6 comments
Closed

Already Saved Query with enabled Save Query Button #3548

carlosmbe opened this issue May 31, 2023 · 6 comments
Labels
1 - Bug Incorrect behavior of the product res:duplicate Duplicate of an existing issue

Comments

@carlosmbe
Copy link
Contributor

Describe the bug
This particular query is already saved. However, I am able to use the Save Query Button and it leads to a crash.

To Reproduce
Steps to reproduce the behavior:

  1. Go to NHDM -> NHMD Amber -> Queries
  2. Click on DarwinCore Types IV
  3. Click Save Query
  4. See error

Expected behavior
A disabled Save Query Button

Evidence
Specify 7 Crash Report - 2023-05-31T18_45_16.246Z (1).txt
Specify 7 Crash Report - 2023-05-31T18_45_16.246Z.txt

Low.Bit.mp4

Desktop:

  • OS: Mac OSx Ventura
  • Browser: Chrome
  • Specify 7 Version: 7.8.11

Database Name: NHMD

@carlosmbe carlosmbe added 1 - Bug Incorrect behavior of the product pri:unknown labels May 31, 2023
@melton-jason
Copy link
Contributor

Is this reproducible for other Queries or just this one?
This may be in part (or wholly) due to the fact that that is not a traditional Query.
It looks like this is a Schema Mapping, created in Specify 6.
See related #1385

If you're unfamiliar with what a Schema Mapping is, we have a Helpcast video available on the Speciforum
https://discourse.specifysoftware.org/t/helpcast-schema-mapper/352

@carlosmbe
Copy link
Contributor Author

This reproducible in all DarwinCore Types Queries in this Database. It seems that during the initial load, some changes are applied automatically as Specify prompts me before leaving the query that changes were made.

Screenshot 2023-05-31 at 4 30 27 PM Screenshot 2023-05-31 at 4 28 32 PM

I'll work through the video before investigating further and report my findings

@melton-jason
Copy link
Contributor

@CarolineDenis @grantfitzsimmons
What do you all think about making Schema Mappings readonly until we implement proper support for them?

@CarolineDenis
Copy link
Contributor

@melton-jason that sounds like a reasonable solution

@maxpatiiuk
Copy link
Member

Duplicate of #1385
This applies only to schema mappings, not regular queries - in sp6 schema mappings are not shown in the list of queries, because there is a separate menu for schema mappings
This should be fixed as part of #285

@maxpatiiuk maxpatiiuk closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Front-End Backlog Jun 1, 2023
@maxpatiiuk maxpatiiuk added the res:duplicate Duplicate of an existing issue label Jun 1, 2023
@grantfitzsimmons
Copy link
Member

@CarolineDenis @grantfitzsimmons What do you all think about making Schema Mappings readonly until we implement proper support for them?

We need to make it clear to the user that it is not a query but a schema mapping in the interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product res:duplicate Duplicate of an existing issue
Projects
None yet
Development

No branches or pull requests

5 participants