Replies: 1 comment
-
Not really. Feel free to send a PR to make all |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
So, this may be a very specific use case, but currently CallWebhookJob has two private methods:
dispatchEvent
andgenerateBody
.The project already allows you to provide your own
CallWebhookJob
class, but instead of having to rewrite the entire logic, it can be useful to simply extend the existingCallWebhookJob
class and overwrite specific methods.The one I am particularly interested in is
generateBody
as I want to canonicalize the json payload instead of relying on PHP'sjson_encode
. I am currently making it work by extending the existing class and copy-pasting bothhandle
anddispatchEvent
(along with all the relevantuse
statements) and overriding thegenerateBody
method, but it would be a lot cleaner if I could just override that method and ignore the rest.Is there a specific reason why those to methods are set to private while most others are protected (or public)?
Beta Was this translation helpful? Give feedback.
All reactions