Docs

caspervdw · caspervdw · commit c50fb3e1d01f · 2018-11-03T17:22:12.000+01:00
diff --git a/pims/display.py b/pims/display.py
@@ -124,10 +124,11 @@ def export_pyav(sequence, filename, rate=30, bitrate=None,
 
     output = av.open(str(filename), str('w'), format=format)
     try:
+        # from PyAv 6.0, options can be supplied here
         stream = output.add_stream(
             codec, rate=export_rate_frac, options=options
         )
-    except TypeError:  # pyav 0.4 compat: supply options at .open
+    except TypeError:  # before, we should supply it at .open
         output = av.open(
             str(filename), str('w'), format=format, options=options
         )

Original file line number	Diff line number	Diff line change
`@@ -124,10 +124,11 @@ def export_pyav(sequence, filename, rate=30, bitrate=None,`
`124`	`124`
`125`	`125`	`output = av.open(str(filename), str('w'), format=format)`
`126`	`126`	`try:`
	`127`	`+ # from PyAv 6.0, options can be supplied here`
`127`	`128`	`stream = output.add_stream(`
`128`	`129`	`codec, rate=export_rate_frac, options=options`
`129`	`130`	`)`
`130`		`- except TypeError: # pyav 0.4 compat: supply options at .open`
	`131`	`+ except TypeError: # before, we should supply it at .open`
`131`	`132`	`output = av.open(`
`132`	`133`	`str(filename), str('w'), format=format, options=options`
`133`	`134`	`)`