fix: use brovider by default in starknet verify (#1190)

* fix: use brovider by default

### Summary
- removed unused rpc URLs from networks.json
- use `getProvider` from utils instead of custom one (which is same as in utils, but uses brovider)

### How to test
- `yarn test` should work now (previously it will throw blast api error)

* v0.14.17

Author: ChaituVR

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@snapshot-labs/snapshot.js",
-  "version": "0.14.16",
+  "version": "0.14.17",
   "repository": "snapshot-labs/snapshot.js",
   "license": "MIT",
   "main": "dist/snapshot.cjs.js",

src/networks.json

@@ -2026,9 +2026,7 @@
     "explorer": {
       "url": "https://starkscan.co"
     },
-    "rpc": [
-      "https://starknet-mainnet.public.blastapi.io"
-    ],
+    "rpc": [],
     "start": 8446,
     "logo": "ipfs://bafkreihbjafyh7eud7r6e5743esaamifcttsvbspfwcrfoc5ykodjdi67m"
   },
@@ -2045,9 +2043,7 @@
     "explorer": {
       "url": "https://sepolia.starkscan.co"
     },
-    "rpc": [
-      "https://starknet-sepolia.public.blastapi.io"
-    ],
+    "rpc": [],
     "start": 7,
     "logo": "ipfs://bafkreihbjafyh7eud7r6e5743esaamifcttsvbspfwcrfoc5ykodjdi67m"
   }

src/verify/starknet.spec.ts

@@ -39,7 +39,7 @@ describe('verify/starknet', () => {
     ])('with a %s signature', (_, message, multisign = false) => {
       test('should return true if the signature is valid', () => {
         expect(
-          verify(message.address, message.sig, message.data, 'SN_MAIN')
+          verify(message.address, message.sig, message.data, '0x534e5f4d41494e')
         ).resolves.toBe(true);
       });
 
@@ -49,21 +49,31 @@ describe('verify/starknet', () => {
             validateAndParseAddress(message.address),
             message.sig,
             message.data,
-            'SN_MAIN'
+            '0x534e5f4d41494e'
           )
         ).resolves.toBe(true);
       });
 
       if (multisign) {
         test('should throw an error when verifying on a different network', () => {
           expect(
-            verify(message.address, message.sig, message.data, 'SN_SEPOLIA')
+            verify(
+              message.address,
+              message.sig,
+              message.data,
+              '0x534e5f5345504f4c4941'
+            )
           ).rejects.toThrowError();
         });
       } else {
         test('should return true when verifying on a different network', () => {
           expect(
-            verify(message.address, message.sig, message.data, 'SN_SEPOLIA')
+            verify(
+              message.address,
+              message.sig,
+              message.data,
+              '0x534e5f5345504f4c4941'
+            )
           ).resolves.toBe(true);
         });
       }
@@ -85,7 +95,7 @@ describe('verify/starknet', () => {
           '0x07f71118e351c02f6EC7099C8CDf93AED66CEd8406E94631cC91637f7D7F203A',
           starknetMessage.sig,
           starknetMessage.data,
-          'SN_MAIN'
+          '0x534e5f4d41494e'
         )
       ).rejects.toThrowError('Contract not deployed');
     });
@@ -96,7 +106,7 @@ describe('verify/starknet', () => {
           starknetMessage.address,
           ['1', '2'],
           starknetMessage.data,
-          'SN_MAIN'
+          '0x534e5f4d41494e'
         )
       ).resolves.toBe(false);
     });
@@ -106,13 +116,23 @@ describe('verify/starknet', () => {
       data.message.timestamp = 1234;
 
       expect(
-        verify(starknetMessage.address, starknetMessage.sig, data, 'SN_MAIN')
+        verify(
+          starknetMessage.address,
+          starknetMessage.sig,
+          data,
+          '0x534e5f4d41494e'
+        )
       ).resolves.toBe(false);
     });
 
     test('should return false when the signature is not valid', () => {
       expect(
-        verify(starknetMessage.address, ['1'], starknetMessage.data, 'SN_MAIN')
+        verify(
+          starknetMessage.address,
+          ['1'],
+          starknetMessage.data,
+          '0x534e5f4d41494e'
+        )
       ).resolves.toBe(false);
     });
   });

src/verify/starknet.ts

@@ -1,22 +1,7 @@
-import { RpcProvider, typedData, constants, TypedData } from 'starknet';
-import networks from '../networks.json';
+import { typedData, TypedData } from 'starknet';
 import type { ProviderOptions } from '../utils/provider';
 import type { SignaturePayload } from '.';
-
-export type NetworkType = 'SN_MAIN' | 'SN_SEPOLIA';
-
-const RPC_URLS: Record<NetworkType, string> = {
-  SN_MAIN: networks[constants.StarknetChainId.SN_MAIN]?.rpc?.[0],
-  SN_SEPOLIA: networks[constants.StarknetChainId.SN_SEPOLIA]?.rpc?.[0]
-};
-
-function getProvider(network: NetworkType, options: ProviderOptions) {
-  if (!RPC_URLS[network]) throw new Error('Invalid network');
-
-  return new RpcProvider({
-    nodeUrl: options?.broviderUrl ?? RPC_URLS[network]
-  });
-}
+import getProvider from '../utils/provider';
 
 export function isStarknetMessage(data: SignaturePayload): boolean {
   return !!data.primaryType && !!data.types.StarkNetDomain;
@@ -36,7 +21,7 @@ export default async function verify(
   address: string,
   sig: string[],
   data: SignaturePayload,
-  network: NetworkType = 'SN_MAIN',
+  network = '0x534e5f4d41494e',
   options: ProviderOptions = {}
 ): Promise<boolean> {
   try {