From befa138d695dfb2752696a25a6231a3b853cf206 Mon Sep 17 00:00:00 2001 From: Jim Date: Fri, 27 Jul 2018 15:51:00 -0400 Subject: [PATCH] Eliminate all lint warnings Fixes #1 --- .eslintignore | 2 ++ examples/.eslintrc.js | 3 +++ package.json | 4 ++-- test/.eslintrc.js | 3 +++ test/04-version-stamp.js | 2 +- test/05-examples.js | 4 ++-- 6 files changed, 13 insertions(+), 5 deletions(-) create mode 100644 .eslintignore diff --git a/.eslintignore b/.eslintignore new file mode 100644 index 0000000..da7e672 --- /dev/null +++ b/.eslintignore @@ -0,0 +1,2 @@ +coverage/**/*.js +examples/**/*.bundle.js diff --git a/examples/.eslintrc.js b/examples/.eslintrc.js index 838cb16..8ff8135 100644 --- a/examples/.eslintrc.js +++ b/examples/.eslintrc.js @@ -1,5 +1,8 @@ module.exports = { "env": { "node": true, + }, + "rules": { + "no-console": [0], } }; diff --git a/package.json b/package.json index d16f4b1..a026108 100644 --- a/package.json +++ b/package.json @@ -41,8 +41,8 @@ "copy-webpack-plugin": "^4.0.1", "eslint": "^3.14.0", "mkdirp": "^0.5.1", - "mocha": "^3.2.0", - "nyc": "^10.1.2", + "mocha": "^5.2.0", + "nyc": "^13.0.1", "webpack": "^1.14.0" } } diff --git a/test/.eslintrc.js b/test/.eslintrc.js index f0c5ae3..c2ea69b 100644 --- a/test/.eslintrc.js +++ b/test/.eslintrc.js @@ -3,4 +3,7 @@ module.exports = { "node": true, "mocha": true }, + "rules": { + "no-console": [0], + } }; diff --git a/test/04-version-stamp.js b/test/04-version-stamp.js index 2b35d99..46b32b3 100644 --- a/test/04-version-stamp.js +++ b/test/04-version-stamp.js @@ -101,7 +101,7 @@ describe("version-stamp VersionStamp", function () { var filename; before("create a temporary build file", function (done) { filename = path.normalize(".build"); - fs.unlink(filename, function (err) { + fs.unlink(filename, function () { fs.writeFile(filename, "1", function (err) { done(err); }); diff --git a/test/05-examples.js b/test/05-examples.js index bcb732c..d676745 100644 --- a/test/05-examples.js +++ b/test/05-examples.js @@ -118,7 +118,7 @@ const failingExamples = [ ]; describe("examples", function () { - for (var i = 0, len = examples.length; i < len; ++i) { + for (let i = 0, len = examples.length; i < len; ++i) { (function (name) { it("should run the " +name+ " example.", function (done) { this.timeout(2000); @@ -134,7 +134,7 @@ describe("examples", function () { }); })(examples[i]); } - for (var i = 0, len = failingExamples.length; i < len; ++i) { + for (let i = 0, len = failingExamples.length; i < len; ++i) { (function (name) { it("should fail the " +name+ " example.", function (done) { this.timeout(2000);