This repository was archived by the owner on Oct 12, 2018. It is now read-only.
Automatically rotate tokens #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrulcik
force-pushed
the
rotating-tokens
branch
from
5145b10 to
8a20b1c
Compare
Tokens shouldn't be rotated on every single request, because that would mean each request would require a new "login" request to get the new token. Instead, we want to reset the token every time login credentials are sent to get the token that should be used for authentication. This is the desired behavior - when someone logs in, revoke any other tokens regardless of expiration. This ensures that only one client is logged in at once.
skrulcik
force-pushed
the
rotating-tokens
branch
from
8a20b1c to
9dc9e01
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of tpb-dev's work found in this PR on the original expiring tokens repository.
I moved it to a branch on this repo so I could make a few reconciliation commits.
Supersedes #2