Added support of extended data types #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .findFirst() | ||
| .orElseThrow(() -> new IllegalArgumentException("Wrong extended vector type: " + code)); | ||
| } | ||
| } No newline at end of file |
| VARSTRING(253), | ||
| STRING(254), | ||
| GEOMETRY(255); | ||
| GEOMETRY(255), |
There was a problem hiding this comment.
unrelated to PR: do you plan to remove GEOMETRY, or to modify it to correspond to our Geography(point), or just leave it as is?
Collaborator
Author
There was a problem hiding this comment.
At the moment, our Geography(point) data type corresponds to the STRING type in the MySQL client/server protocol. I think it is a nice mapping and would like to leave it as it is.
The GEOMETRY type can be safely removed as it is never actually used.
I believe that the same can be done with OLDDECIMAL, NEWDATE, and NULL
| public DataType getBinaryEncodeType() { | ||
| return DataType.BLOB; | ||
| } | ||
| } No newline at end of file |
| throw new IllegalArgumentException("Unsupported vector type: " + dataType.name()); | ||
| } | ||
| } | ||
| } No newline at end of file |
pmishchenko-ua
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the same functionality as a corresponding PR from JDBC
memsql/S2-JDBC-Connector#22
For simplicity, the vectorTypeOutputFormat configuration is not added (the same functionality can be achieved using session variables).