Skip to content

buff_t uses 'player' variable name to refer to buff's target #10060

@Azevara

Description

@Azevara

Describe the bug

When constructing buff_t, both a source and target are set. However, the target is labeled "player" internally, which might lead to unexpected behavior if the wrong actor is used as a result of this name.

This was found in #10059 , but there may be other places within buff.cpp that are similarly affected. The issue requires further in-depth review to confirm if this was the only errant usage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions