Merge pull request #273 from silinternational/feature/fix-warnings

CVR-788 fix warnings

Author: hobbitronics

components/custom/FileDropArea/FileDropArea.svelte

@@ -73,36 +73,35 @@ form > * {
 }
 </style>
 
-<div
+<form
   id="drop-area"
-  class="br-8px {$$props.class || ''}"
+  class="br-8px flex justify-between align-items-center py-1 px-1 {$$props.class || ''}"
   class:highlighted
   on:dragenter|preventDefault|stopPropagation={highlight}
   on:dragleave|preventDefault|stopPropagation={unhighlight}
   on:dragover|preventDefault|stopPropagation={highlight}
   on:drop|preventDefault|stopPropagation={handleDrop}
+  class:column={!isAboveMobile()}
 >
-  <form class="flex justify-between align-items-center my-1 px-1" class:column={!isAboveMobile()}>
-    {#if !uploading}
-      <input
-        bind:this={fileInput}
-        type="file"
-        id="fileElem"
-        multiple
-        accept={mimeType}
-        disabled={uploading}
-        on:change={() => handleFiles(fileInput.files)}
-      />
-    {/if}
-    <label
-      class="mdc-button m-8px"
-      for="fileElem"
-      class:custom-text-button={raised}
-      class:mdc-button--outlined={outlined}
-      class:disabled={uploading}
-      class:mdc-button--raised={raised}>Choose files</label
-    >
-    <div class="m-8px">or drop files here</div>
-    <i class="material-icons icon m-8px" id="upload-icon">cloud_upload</i>
-  </form>
-</div>
+  {#if !uploading}
+    <input
+      bind:this={fileInput}
+      type="file"
+      id="fileElem"
+      multiple
+      accept={mimeType}
+      disabled={uploading}
+      on:change={() => handleFiles(fileInput.files)}
+    />
+  {/if}
+  <label
+    class="mdc-button m-8px"
+    for="fileElem"
+    class:custom-text-button={raised}
+    class:mdc-button--outlined={outlined}
+    class:disabled={uploading}
+    class:mdc-button--raised={raised}>Choose files</label
+  >
+  <div class="m-8px">or drop files here</div>
+  <i class="material-icons icon m-8px" id="upload-icon">cloud_upload</i>
+</form>

components/mdc/Card/Card.svelte

@@ -31,6 +31,7 @@ $: tabindex = isClickable ? 0 : undefined
 </style>
 
 <div
+  role="button"
   {tabindex}
   class="mdc-card mdc-typography {$$props.class || ''}"
   style="background-color: {color}"

components/mdc/List/Item.svelte

@@ -51,35 +51,32 @@ img {
   class:mdc-deprecated-list-item--activated={activated}
   class:mdc-deprecated-list-item--disabled={nonInteractive}
   data-mdc-dialog-action={$$props['data-mdc-dialog-action']}
-  on:click
-  on:keydown
-  on:keypress
-  on:keyup
-  {tabindex}
 >
-  {#if graphicURL}
-    <div class="mdc-deprecated-list-item__graphic">
-      <img class="br-50" alt={graphicAlt} src={graphicURL} />
-    </div>
-  {:else if icon}
-    <i class="material-icons mdc-deprecated-list-item__graphic" aria-hidden="true">{icon}</i>
-  {/if}
+  <div role="button" {tabindex} on:click on:keydown on:keypress on:keyup>
+    {#if graphicURL}
+      <div class="mdc-deprecated-list-item__graphic">
+        <img class="br-50" alt={graphicAlt} src={graphicURL} />
+      </div>
+    {:else if icon}
+      <i class="material-icons mdc-deprecated-list-item__graphic" aria-hidden="true">{icon}</i>
+    {/if}
 
-  <span class="mdc-deprecated-list-item__ripple" />
+    <span class="mdc-deprecated-list-item__ripple" />
 
-  <span class="mdc-deprecated-list-item__text" class:nonInteractive>
-    {#if primary || secondary}
-      <span class="mdc-deprecated-list-item__primary-text">{primary}</span>
-      <span class="mdc-deprecated-list-item__secondary-text">{secondary}</span>
-    {:else}
-      {text}
-      <slot />
-    {/if}
-  </span>
+    <span class="mdc-deprecated-list-item__text" class:nonInteractive>
+      {#if primary || secondary}
+        <span class="mdc-deprecated-list-item__primary-text">{primary}</span>
+        <span class="mdc-deprecated-list-item__secondary-text">{secondary}</span>
+      {:else}
+        {text}
+        <slot />
+      {/if}
+    </span>
 
-  <div class="mdc-deprecated-list-item__meta">
-    {meta}
-    <slot name="meta" />
+    <div class="mdc-deprecated-list-item__meta">
+      {meta}
+      <slot name="meta" />
+    </div>
   </div>
 </li>