Merge pull request #22 from khiminrm/21-fix-transaction-response

Fix TransactionResponse, move duplicated code to Response class.

Author: ebanolopes

lib/Core/Response.php

@@ -34,17 +34,72 @@ public function __construct($response = [])
 
     }
 
-    /**
-     * Setting the error for the object
+   /**
+     * Set the error
      *
-     * @param int|string $httpCode The http status code
-     * @param string     $error    The error message
+     * @param int    $httpCode The response code
+     * @param string $error    The response
      *
      * @return void
      */
     public function setError($httpCode, $error)
     {
+      $this->setIsError(true);
+      $this->setErrorMessage($error);
+    }
+
+    /**
+     * Set the error for the response object
+     *
+     * @param bool $isError The error state
+     *
+     * @return void
+     */
+    public function setIsError($isError)
+    {
+      $this->isError = $isError;
+    }
+
+    /**
+     * Is the response in error
+     *
+     * @return bool
+     */
+    public function isError()
+    {
+      return $this->isError;
+    }
+
+    /**
+     * Get the error message
+     *
+     * @return string
+     */
+    public function getErrorMessage()
+    {
+      return $this->errorMessage;
+    }
 
+    /**
+     * Set the error message
+     *
+     * @param string $errorMessage The error message
+     *
+     * @return void
+     */
+    public function setErrorMessage($errorMessage)
+    {
+      $this->errorMessage = $errorMessage;
+    }
+
+    /**
+     * Get if there is an error
+     *
+     * @return bool
+     */
+    public function isError()
+    {
+      return $this->isError;
     }
 
     /**
@@ -58,4 +113,4 @@ public function setObject($response)
     {
 
     }
-}
+}

lib/Core/Response/CaseResponse.php

@@ -279,20 +279,6 @@ public function setMethod($method, $item)
         }
     }
 
-    /**
-     * Set the error
-     *
-     * @param int    $httpCode The response code
-     * @param string $error    The response
-     *
-     * @return void
-     */
-    public function setError($httpCode, $error)
-    {
-        $this->setIsError(true);
-        $this->setErrorMessage($error);
-    }
-
     /**
      * Get the eligible for guarantee
      *
@@ -625,51 +611,6 @@ public function setUpdatedAt($updatedAt)
         $this->updatedAt = $updatedAt;
     }
 
-    /**
-     * Is the response in error
-     *
-     * @return bool
-     */
-    public function isError()
-    {
-        return $this->isError;
-    }
-
-    /**
-     * Set the error for the response object
-     *
-     * @param bool $isError The error state
-     *
-     * @return void
-     */
-    public function setIsError($isError)
-    {
-        $this->isError = $isError;
-    }
-
-    /**
-     * Get the error message
-     *
-     * @return string
-     */
-    public function getErrorMessage()
-    {
-        return $this->errorMessage;
-    }
-
-    /**
-     * Set the error message
-     *
-     * @param string $errorMessage The error message
-     *
-     * @return void
-     */
-    public function setErrorMessage($errorMessage)
-    {
-        $this->errorMessage = $errorMessage;
-    }
-
-
     /**
      * Set the investigation id to the case id
      *
@@ -851,9 +792,4 @@ public function setGuaranteeIneligibleReason($guaranteeIneligibleReason)
     {
         $this->guaranteeIneligibleReason = $guaranteeIneligibleReason;
     }
-
-    public function addMessage($message)
-    {
-        $this->message[] = $message;
-    }
-}
+}

lib/Core/Response/FulfillmentBulkResponse.php

@@ -72,51 +72,6 @@ public function __construct($logger)
         $this->logger = $logger;
     }
 
-    /**
-     * Is the response in error
-     *
-     * @return bool
-     */
-    public function isError()
-    {
-        return $this->isError;
-    }
-
-    /**
-     * Set the response error
-     *
-     * @param bool $isError If response is in error
-     *
-     * @return void
-     */
-    public function setIsError($isError)
-    {
-        $this->isError = $isError;
-    }
-
-    /**
-     * Get the error message
-     *
-     * @return string
-     */
-    public function getErrorMessage()
-    {
-        return $this->errorMessage;
-    }
-
-    /**
-     * Set the error message
-     *
-     * @param string $errorMessage The error message
-     *
-     * @return void
-     */
-    public function setErrorMessage($errorMessage)
-    {
-        $this->errorMessage = $errorMessage;
-    }
-
-
     /**
      * Get the response objects
      *
@@ -143,17 +98,4 @@ public function setObject($response)
         }
     }
 
-    /**
-     * Set the error
-     *
-     * @param int    $httpCode The response code
-     * @param string $error    The response
-     *
-     * @return void
-     */
-    public function setError($httpCode, $error)
-    {
-        $this->setIsError(true);
-        $this->setErrorMessage($error);
-    }
-}
+}

lib/Core/Response/GuaranteeResponse.php

@@ -149,63 +149,6 @@ public function setObject($response)
         return true;
     }
 
-    /**
-     * Set the error
-     *
-     * @param int    $httpCode The response code
-     * @param string $error    The response
-     *
-     * @return void
-     */
-    public function setError($httpCode, $error)
-    {
-        $this->setIsError(true);
-        $this->setErrorMessage($error);
-    }
-
-    /**
-     * Is the response in error
-     *
-     * @return bool
-     */
-    public function isError()
-    {
-        return $this->isError;
-    }
-
-    /**
-     * Set the error for the response object
-     *
-     * @param bool $isError The error state
-     *
-     * @return void
-     */
-    public function setIsError($isError)
-    {
-        $this->isError = $isError;
-    }
-
-    /**
-     * Get the error message
-     *
-     * @return string
-     */
-    public function getErrorMessage()
-    {
-        return $this->errorMessage;
-    }
-
-    /**
-     * Set the error message
-     *
-     * @param string $errorMessage The error message
-     *
-     * @return void
-     */
-    public function setErrorMessage($errorMessage)
-    {
-        $this->errorMessage = $errorMessage;
-    }
 
     /**
      * Get the case id
@@ -383,4 +326,4 @@ public function setGuaranteeId($guaranteeId)
         $this->guaranteeId = $guaranteeId;
     }
 
-}
+}

lib/Core/Response/TransactionsResponse.php

@@ -4,9 +4,10 @@
 
 use Signifyd\Core\Exceptions\LoggerException;
 use Signifyd\Core\Model;
+use Signifyd\Core\Response;
 use Signifyd\Models\Transaction;
 
-class TransactionsResponse extends Model
+class TransactionsResponse extends Response
 {
     /**
      * A unique id for a particular checkout.
@@ -121,9 +122,4 @@ public function addTransaction($transaction)
     {
         $this->transactions[] = $transaction;
     }
-
-    public function addMessage($message)
-    {
-        $this->message[] = $message;
-    }
 }