JakartaEE Descriptors

[stbischof]

I am willing to add JakartaEE Descriptors.

but before I start it would be important to know if someone would merge and create at release.

Is there someone who is willing and able to merge and release?

[petrberan]

Hi @stbischof . I've recently taken over the Shrinkwrap project and I haven't got the time to get to Descriptors just yet, but I can merge PRs and release new versions so feel free to give it a shot 👍

[stbischof]

any opinions on the java version?

java 5 /6 as in setup should not be the goal.

With JAVA 9+ we cant use _ in enums

but package org.jboss.shrinkwrap.descriptor.api.webapp25.NullCharType;

uses this.

 */
public enum NullCharType
{
   _("");

   private String value;

so update over java8 breaks API because needs rework on transformation to not use _ and element of enum

[petrberan]

Personally I would stick with Java 8 for now. The rest of Shrinkwrap also uses Java 8 and although I would love to go for 11 (or even 17 or 21), I'd prefer to stabilize the code now and bump the version later

[stbischof]

@petrberan what is the default branch? 2.0.0-X seems the newest

I made #116 master branch
and #117 for 2.0.0-X branch

[petrberan]

@stbischof Sorry, I've been busy with preparing a conference lately, I'll have a look at those PRs soon.

As for the branch, it really seems that 2.0.0-X has some newer commits. Though I must say I'm not a fan of having non-"main" branch named as a maintenance one and the "main" being behind. Over the time I'd love to leave the 2.0.0-X as a maintenance and release 3.0.0 from Main branch, using the Java version bump as a fresh start

[stbischof]

I would rename the 2.0.0-X to main.
Since the ond braches name is master we also had to fix this.

And than update there to a 3.0.0.

And just tag for Version releases. Just devel on main is best.

[petrberan]

Sounds good to me.

Can't find anything that's in master and not in 2.0.0-X so I'll close the master, duplicate the 2.0.0-X for maintenance and make the 2.0.0-X the new main.