Writing to wrong stream

[alejandro-colomar]

shadow/src/vipw.c

Lines 79 to 101 in 36debf3

	/*
	* usage - display usage message and exit
	*/
	static void usage (int status)
	{
	FILE *usageout = (E_SUCCESS != status) ? stderr : stdout;
	(void) fprintf (stderr,
	_("Usage: %s [options]\n"
	"\n"
	"Options:\n"),
	Prog);
	(void) fputs (_(" -g, --group edit group database\n"), usageout);
	(void) fputs (_(" -h, --help display this help message and exit\n"), usageout);
	(void) fputs (_(" -p, --passwd edit passwd database\n"), usageout);
	(void) fputs (_(" -q, --quiet quiet mode\n"), usageout);
	(void) fputs (_(" -R, --root CHROOT_DIR directory to chroot into\n"), usageout);
	(void) fputs (_(" -s, --shadow edit shadow or gshadow database\n"), usageout);
	#ifdef WITH_TCB
	(void) fputs (_(" -u, --user which user's tcb shadow file to edit\n"), usageout);
	#endif /* WITH_TCB */
	(void) fputs (_("\n"), usageout);
	exit (status);
	}

Why is that fprintf(3) hardcoded to stderr? It looks like a bug. It should be writing to usageout, no?

[ikerexxe]

Yes, that should be printed to usageout

[alejandro-colomar]

I've open a PR that fixes this. It also does some simplification of fprintf() calls. Please have a look: #1289