rename label to "Profiles with users", add test to restrict access to admins

Author: MasoudAbedi

app/controllers/admin_controller.rb

@@ -513,7 +513,7 @@ def get_user_stats
       partial = 'user_stats_list'
       collection = Person.pals
       title = 'List of PALs'
-    when 'registered_users'
+    when 'profiles_with_users'
       partial = 'user_stats_list'
       collection  = Person.registered
       title = 'All Profiles'

app/views/admin/_stats.html.erb

@@ -15,7 +15,7 @@
                     ["Non-#{t('project')} Members","non_project_members"],
                     ["PALs","pals"],
                     ["Profiles without users","profiles_without_users"],
-                    ["Registered users", "registered_users"]]
+                    ["Profiles with users", "profiles_with_users"]]
 
     grouped_options = [['Status', status_options], ['Statistics', statistics_options], ['User Information', user_options]]
   %>

test/functional/admin_controller_test.rb

@@ -198,16 +198,26 @@ def setup
     assert User.current_user.person.is_admin?
   end
 
-  test 'get registered users' do
-    user = FactoryBot.create(:user, email: '[email protected]')
+  test 'admin can get profiles with users stats' do
+    user = FactoryBot.create(:admin)
+    login_as(user)
     person_with_user = user.person
     person_without_user = FactoryBot.create(:person, user: nil)
-    get :get_stats, xhr: true, params: { page: 'registered_users' }
+    get :get_stats, xhr: true, params: { page: 'profiles_with_users' }
     assert_response :success
     assert_match person_with_user.name, response.body
     refute_match person_without_user.name, response.body
   end
 
+  test 'non-admin cannot access profiles with users stats' do
+    user = FactoryBot.create(:user)
+    login_as(user)
+    get :get_stats, xhr: true, params: { page: 'profiles_with_users' }
+    assert_response :redirect
+    assert_redirected_to root_path
+    refute_nil flash[:error]
+  end
+
   test 'get project content stats' do
     get :get_stats, xhr: true, params: { page: 'content_stats' }
     assert_response :success