Skip to content

Conversation

@sdubov
Copy link
Owner

@sdubov sdubov commented Oct 5, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • Add DotNet lamda run configuraiton validation logic to run async call to check PSI for handler
  • Add async protocol call to define if handler valid to be able to get results from any thread
  • Add tests to verify handler validation logic with DotNet runtime

Motivation and Context

None.

Related Issue(s)

None.

Testing

None.

Screenshots (if appropriate)

None.

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • Local run of gradlew check succeeds
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Add DotNet lamda run configuraiton validation logic to run async call to check PSI for handler
* Add async protocol call to define if handler valid to be able to get results from any thread
* Add tests to verify handler validation logic with DotNet runtime
@codecov-io
Copy link

codecov-io commented Oct 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (feature/rider-support@19b8858). Click here to learn what that means.
The diff coverage is 16.66%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             feature/rider-support       #7   +/-   ##
========================================================
  Coverage                         ?   46.42%           
  Complexity                       ?      776           
========================================================
  Files                            ?      215           
  Lines                            ?     7431           
  Branches                         ?     1100           
========================================================
  Hits                             ?     3450           
  Misses                           ?     3529           
  Partials                         ?      452
Flag Coverage Δ Complexity Δ
#unittest 46.42% <16.66%> (?) 776 <1> (?)
Impacted Files Coverage Δ Complexity Δ
.../toolkits/jetbrains/utils/CachingAsyncEvaluator.kt 74.41% <ø> (ø) 11 <0> (?)
...ution/local/LocalLambdaRunSettingsEditorPanel.java 0% <0%> (ø) 0 <0> (?)
...vices/lambda/dotnet/DotNetLambdaHandlerResolver.kt 0% <0%> (ø) 0 <0> (?)
...oolkits/jetbrains/services/lambda/LambdaPsiHost.kt 100% <100%> (ø) 1 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b8858...ae7e967. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants