Merge pull request #823 from ArturGaspar/fix_exposedrequest_lua_attributes

Fix Lua attribute types in _ExposedRequest.

Author: kmike

splash/qtrender_lua.py

@@ -2032,8 +2032,8 @@ class _ExposedRequest(BaseExposedObject):
 
     def __init__(self, lua, exceptions, url, method, headers, info):
         super(_ExposedRequest, self).__init__(lua, exceptions)
-        self.url = url
-        self.method = method
+        self.url = self.lua.python2lua(url)
+        self.method = self.lua.python2lua(method)
         # TODO: make info and headers attributes lazy
         self.headers = self.lua.python2lua(headers, encoding='latin1')
         self.info = self.lua.python2lua(info)

splash/tests/test_execute_callbacks.py

@@ -502,7 +502,11 @@ def test_on_response(self):
                         info=response.request.info,
                         headers = response.request.headers,
                         url = response.request.url,
+                        url_comparison = (
+                            response.request.url == splash.args.url
+                        ),
                         method = response.request.method,
+                        method_comparison = (response.request.method == "GET")
                     }
                 }
                 result[#result+1] = resp_info
@@ -540,6 +544,7 @@ def test_on_response(self):
 
         self.assertEqual(e1['request']['info']['url'], url)
         self.assertEqual(e1['request']['url'], url)
+        self.assertEqual(e1['request']['url_comparison'], True)
 
         self.assertEqual(e1['request']['info']['headers'], h1['request']['headers'])
         self.assertEqual(e1['request']['headers'], {
@@ -551,6 +556,7 @@ def test_on_response(self):
             self.assertIn('User-Agent', entry['request']['headers'])
 
         self.assertEqual(e1['request']['method'], 'GET')
+        self.assertEqual(e1['request']['method_comparison'], True)
         self.assertEqual(e1['request']['info']['method'], 'GET')
 
         self.assertEqual(e1['request']['info']['cookies'], h1['request']['cookies'])