Skip to content

Retain backwards compatibility with "ignore" configuration option. #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
quinnmil opened this issue May 6, 2025 · 1 comment · May be fixed by #812
Closed

Retain backwards compatibility with "ignore" configuration option. #811

quinnmil opened this issue May 6, 2025 · 1 comment · May be fixed by #812

Comments

@quinnmil
Copy link
Contributor

quinnmil commented May 6, 2025

When we implemented more advanced sampling support, we deprecated the ignore config option, which was used to ignore endpoints before. We should retain backwards compatibility here by treating (or combining) the ignore configuration with the ignore_endpoint configuration.
@quinnmil quinnmil linked a pull request May 6, 2025 that will close this issue
Check ignore value for legacy configuration #812
Open
@quinnmil
Copy link
Contributor Author

quinnmil commented May 7, 2025

This is already supported via logic in the sampler. We're going to add a test to clarify this in the future.

@quinnmil quinnmil closed this as completed May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check ignore value for legacy configuration scoutapp/scout_apm_python
1 participant
@quinnmil