set write buffer to same size used for read buffer

Author: briansorahan

conn.go

@@ -8,7 +8,7 @@ import (
 )
 
 const (
-	readBufSize = 4096
+	bufSize = 4096 // Size of read and write buffers.
 )
 
 // Common errors.

udp.go

@@ -12,6 +12,7 @@ type udpConn interface {
 	net.Conn
 
 	ReadFromUDP([]byte) (int, *net.UDPAddr, error)
+	SetWriteBuffer(bytes int) error
 	WriteTo([]byte, net.Addr) (int, error)
 }
 
@@ -34,12 +35,13 @@ func DialUDPContext(ctx context.Context, network string, laddr, raddr *net.UDPAd
 	if err != nil {
 		return nil, err
 	}
-	return &UDPConn{
+	uc := &UDPConn{
 		udpConn:   conn,
 		closeChan: make(chan struct{}),
 		ctx:       ctx,
 		errChan:   make(chan error),
-	}, nil
+	}
+	return uc.initialize()
 }
 
 // ListenUDP creates a new UDP server.
@@ -53,12 +55,21 @@ func ListenUDPContext(ctx context.Context, network string, laddr *net.UDPAddr) (
 	if err != nil {
 		return nil, err
 	}
-	return &UDPConn{
+	uc := &UDPConn{
 		udpConn:   conn,
 		closeChan: make(chan struct{}),
 		ctx:       ctx,
 		errChan:   make(chan error),
-	}, nil
+	}
+	return uc.initialize()
+}
+
+// initialize initializes a UDP connection.
+func (conn *UDPConn) initialize() (*UDPConn, error) {
+	if err := conn.udpConn.SetWriteBuffer(bufSize); err != nil {
+		return nil, errors.Wrap(err, "setting write buffer size")
+	}
+	return conn, nil
 }
 
 // Context returns the context associated with the conn.
@@ -114,7 +125,7 @@ func (conn *UDPConn) Serve(dispatcher Dispatcher) error {
 
 // serve retrieves OSC packets.
 func (conn *UDPConn) serve(dispatcher Dispatcher, errChan chan error) {
-	data := make([]byte, readBufSize)
+	data := make([]byte, bufSize)
 
 	_, sender, err := conn.ReadFromUDP(data)
 	if err != nil {

udp_test.go

@@ -36,6 +36,17 @@ func TestDialUDP(t *testing.T) {
 	}
 }
 
+func TestDialUDPSetWriteBufferError(t *testing.T) {
+	uc := &UDPConn{udpConn: errConn{}}
+	_, err := uc.initialize()
+	if err == nil {
+		t.Fatal("expected error, got nil")
+	}
+	if expected, got := `setting write buffer size: derp`, err.Error(); expected != got {
+		t.Fatalf("expected %s, got %s", expected, got)
+	}
+}
+
 func TestListenUDP(t *testing.T) {
 	if _, err := ListenUDP("asdfiauosweif", nil); err == nil {
 		t.Fatal("expected error, got nil")
@@ -114,6 +125,7 @@ func TestUDPConnSend_OK(t *testing.T) {
 	}
 }
 
+// errConn is an implementation of the udpConn interface that returns errors from all it's methods.
 type errConn struct {
 	udpConn
 }
@@ -122,6 +134,10 @@ func (e errConn) ReadFromUDP(b []byte) (int, *net.UDPAddr, error) {
 	return 0, nil, errors.New("oops")
 }
 
+func (e errConn) SetWriteBuffer(bytes int) error {
+	return errors.New("derp")
+}
+
 func TestUDPConnServe_ContextTimeout(t *testing.T) {
 	laddr, err := net.ResolveUDPAddr("udp", "127.0.0.1:0")
 	if err != nil {