Skip to content

Commit 63147de

Browse files
authored
Merge pull request #92 from djspiewak/bug/graalvm-version-spec
Fixed graalvm version specs
2 parents 28e92a3 + e3b35ea commit 63147de

File tree

6 files changed

+29
-14
lines changed

6 files changed

+29
-14
lines changed

.github/workflows/ci.yml

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
matrix:
2424
os: [ubuntu-latest, macos-latest, windows-latest]
2525
scala: [2.12.15]
26-
java: [temurin@11]
26+
java: [temurin@11, graal_20.3.1@11]
2727
runs-on: ${{ matrix.os }}
2828
steps:
2929
- name: Ignore line ending differences in git
@@ -43,6 +43,13 @@ jobs:
4343
distribution: temurin
4444
java-version: 11
4545

46+
- name: Setup GraalVM (graal_20.3.1@11)
47+
if: matrix.java == 'graal_20.3.1@11'
48+
uses: DeLaGuardo/[email protected]
49+
with:
50+
graalvm: 20.3.1
51+
java: java11
52+
4653
- name: Cache sbt
4754
uses: actions/cache@v2
4855
with:
@@ -99,6 +106,13 @@ jobs:
99106
distribution: temurin
100107
java-version: 11
101108

109+
- name: Setup GraalVM (graal_20.3.1@11)
110+
if: matrix.java == 'graal_20.3.1@11'
111+
uses: DeLaGuardo/[email protected]
112+
with:
113+
graalvm: 20.3.1
114+
java: java11
115+
102116
- name: Cache sbt
103117
uses: actions/cache@v2
104118
with:

build.sbt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ ThisBuild / crossScalaVersions := Seq("2.12.15")
2929

3030
ThisBuild / githubWorkflowOSes := Seq("ubuntu-latest", "macos-latest", "windows-latest")
3131
ThisBuild / githubWorkflowBuild := Seq(WorkflowStep.Sbt(List("test", "scripted")))
32+
ThisBuild / githubWorkflowJavaVersions += JavaSpec.graalvm("20.3.1", "11")
3233

3334
// dummy publication just to test that setup works
3435
ThisBuild / githubWorkflowPublishTargetBranches :=

src/main/scala/sbtghactions/JavaSpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ package sbtghactions
1818

1919
final case class JavaSpec(dist: JavaSpec.Distribution, version: String) {
2020
def render: String = dist match {
21-
case JavaSpec.Distribution.GraalVM(gversion) => s"graal:$gversion@$version"
21+
case JavaSpec.Distribution.GraalVM(gversion) => s"graal_$gversion@$version"
2222
case dist => s"${dist.rendering}@$version"
2323
}
2424
}

src/main/scala/sbtghactions/WorkflowStep.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ object WorkflowStep {
4141
cond = Some(s"matrix.java == '${jv.render}'"),
4242
params = Map(
4343
"graalvm" -> graalVersion,
44-
"java" -> version))
44+
"java" -> s"java$version"))
4545

4646
case jv @ JavaSpec(dist, version) =>
4747
WorkflowStep.Use(

src/sbt-test/sbtghactions/check-and-regenerate/expected-ci.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
matrix:
2525
os: [ubuntu-latest]
2626
scala: [2.13.6, 2.12.15]
27-
java: [temurin@11, 'graal:21.1.0@8']
27+
java: [temurin@11, graal_21.1.0@8]
2828
test: [this, is]
2929
include:
3030
- test: this
@@ -46,12 +46,12 @@ jobs:
4646
distribution: temurin
4747
java-version: 11
4848

49-
- name: 'Setup GraalVM (graal:21.1.0@8)'
50-
if: 'matrix.java == ''graal:21.1.0@8'''
49+
- name: Setup GraalVM (graal_21.1.0@8)
50+
if: matrix.java == 'graal_21.1.0@8'
5151
uses: DeLaGuardo/[email protected]
5252
with:
5353
graalvm: 21.1.0
54-
java: 8
54+
java: java8
5555

5656
- name: Cache sbt
5757
uses: actions/cache@v2
@@ -105,12 +105,12 @@ jobs:
105105
distribution: temurin
106106
java-version: 11
107107

108-
- name: 'Setup GraalVM (graal:21.1.0@8)'
109-
if: 'matrix.java == ''graal:21.1.0@8'''
108+
- name: Setup GraalVM (graal_21.1.0@8)
109+
if: matrix.java == 'graal_21.1.0@8'
110110
uses: DeLaGuardo/[email protected]
111111
with:
112112
graalvm: 21.1.0
113-
java: 8
113+
java: java8
114114

115115
- name: Cache sbt
116116
uses: actions/cache@v2

src/test/scala/sbtghactions/GenerativePluginSpec.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ class GenerativePluginSpec extends Specification {
519519
matrix:
520520
os: [ubuntu-latest]
521521
scala: [2.12.15, 2.13.6]
522-
java: [temurin@11, 'graal:20.0.0@8']
522+
java: [temurin@11, graal_20.0.0@8]
523523
runs-on: $${{ matrix.os }}
524524
steps:
525525
- name: Setup Java (temurin@11)
@@ -529,12 +529,12 @@ class GenerativePluginSpec extends Specification {
529529
distribution: temurin
530530
java-version: 11
531531

532-
- name: 'Setup GraalVM (graal:20.0.0@8)'
533-
if: 'matrix.java == ''graal:20.0.0@8'''
532+
- name: Setup GraalVM (graal_20.0.0@8)
533+
if: matrix.java == 'graal_20.0.0@8'
534534
uses: DeLaGuardo/[email protected]
535535
with:
536536
graalvm: 20.0.0
537-
java: 8"""
537+
java: java8"""
538538
}
539539

540540
"compile a job with environment variables, conditional, and needs with an sbt step" in {

0 commit comments

Comments
 (0)